Problem with key bindings about go-prompt HOT 7 CLOSED

Great! 😄

Thanks a lot for your help.

from go-prompt.

Thanks.
I'm currently investigating.

from go-prompt.

There might be some errors in yours key definitions (i.e. asciiSequences).

For example, here : https://github.com/c-bata/go-prompt/blob/master/vt100_input.go#L146

	{Key: End, ASCIICode: []byte{0x1b, 0x5b, 0x70}},
	{Key: End, ASCIICode: []byte{0x1b, 0x4f, 0x70}},

If you replace 0x70 by 0x46, it works for the 'End' key.

I replaced 0x05 by 0x35, and 0x06 by 0x36 for PageUp and PageDown, and it works:

	{Key: PageUp, ASCIICode: []byte{0x1b, 0x5b, 0x35, 0x7e}},
	{Key: PageDown, ASCIICode: []byte{0x1b, 0x5b, 0x36, 0x7e}},

from go-prompt.

Hi, @SebastienBoisard!
These definition of ascii sequences is migrated from python-prompt-toolkit like:

https://github.com/jonathanslenders/python-prompt-toolkit/blob/4476b3c28add85c5a8169fbb81ded8c3b845e588/prompt_toolkit/terminal/vt100_input.py#L92-L93

End key is properly migrated from python-prompt-toolkit.

But as you said, the ascii sequences of PageUp and PageDown seems to be wrong.
The ascii sequence of 5 is 0x35 and also 6 is 0x36.

https://github.com/jonathanslenders/python-prompt-toolkit/blob/4476b3c28add85c5a8169fbb81ded8c3b845e588/prompt_toolkit/terminal/vt100_input.py#L99-L100

I'll fix. Thanks!

from go-prompt.

This issue is fixed on current master branch.

I'll close this. Thanks!!

from go-prompt.

Hi @c-bata,

From the python-prompt-toolkit, you have this:

    '\x1b[H': Keys.Home,
    '\x1bOH': Keys.Home,
    '\x1b[F': Keys.End,
    '\x1bOF': Keys.End,

and you migrated these keys in Go with:

	{Key: Home, ASCIICode: []byte{0x1b, 0x5b, 0x48}},
	{Key: Home, ASCIICode: []byte{0x1b, 0x4f, 0x48}},
	{Key: End, ASCIICode: []byte{0x1b, 0x5b, 0x70}},
	{Key: End, ASCIICode: []byte{0x1b, 0x4f, 0x70}},

The last value for the 'Home' key is 'H' in Python which you properly translated to 0x48.
But the last value for the 'End' key is 'F' in Python which is not 0x70 but 0x46.

So, I'm pretty sure that the correct code for the 'End' key is this one: 😉

	{Key: End, ASCIICode: []byte{0x1b, 0x5b, 0x46}},
	{Key: End, ASCIICode: []byte{0x1b, 0x4f, 0x46}},

Thanks for your help.

from go-prompt.

Oh I missed 😫
I fixed this at 76a3a21

Thanks!

from go-prompt.