Giter Club home page Giter Club logo

Comments (6)

bwplotka avatar bwplotka commented on May 18, 2024 1

Hi we fixed this in recent release, please check 🤗

https://github.com/bwplotka/bingo/releases/tag/v0.4.0

Your suggested changes would work, but there are some edge cases that had to be fixed too. Thanks!

from bingo.

mvenable avatar mvenable commented on May 18, 2024

This issue appears to be because the go list command requires the go.sum file to exist in go 1.16. To validate this I created a local hack that runs go download (with the modfile variable) to populate the go.sum prior to list being run. After this change all of the tests passed and it appeared to function correctly again.

--- a/get.go
+++ b/get.go
@@ -580,6 +580,10 @@ func install(runnable runner.Runnable, name string, link bool, pkg *bingo.Packag
                return errors.Wrap(err, pkg.String())
        }
 
+       if err := runnable.Download(runner.NoUpdatePolicy); err != nil {
+               return err
+       }
+
        // Check if path is pointing to non-buildable package. Fail it is non-buildable. Hacky!
        if listOutput, err := runnable.List(runner.NoUpdatePolicy, "-f={{.Name}}", pkg.Path()); err != nil {
                return err
--- a/pkg/runner/runner.go
+++ b/pkg/runner/runner.go
@@ -80,6 +80,7 @@ var cmdsSupportingModFileArg = map[string]struct{}{
        "install": {},
        "list":    {},
        "build":   {},
+       "download": {},
 }
 
 func (r *Runner) execGo(ctx context.Context, output io.Writer, cd string, modFile string, args ...string) error {
@@ -121,6 +122,7 @@ func (r *Runner) exec(ctx context.Context, output io.Writer, cd string, command
 }
 
 type Runnable interface {
+       Download(update GetUpdatePolicy, args ...string) error
        List(update GetUpdatePolicy, args ...string) (string, error)
        GetD(update GetUpdatePolicy, packages ...string) (string, error)
        Build(pkg, out string) error
@@ -176,6 +178,19 @@ func (r *runnable) List(update GetUpdatePolicy, args ...string) (string, error)
        return strings.Trim(out.String(), "\n"), nil
 }
 
+// List runs `go list` against separate go modules files if any.
+func (r *runnable) Download(update GetUpdatePolicy, args ...string) error {
+       a := []string{"mod", "download"}
+       if update != NoUpdatePolicy {
+               a = append(a, string(update))
+       }
+       out := &bytes.Buffer{}
+       if err := r.r.execGo(r.ctx, out, r.dir, r.modFile, append(a, args...)...); err != nil {
+               return errors.Wrap(err, out.String())
+       }
+       return nil
+}
+
 // GoEnv runs `go env` with given args.
 func (r *runnable) GoEnv(args ...string) (string, error) {
        out := &bytes.Buffer{}

from bingo.

benmathews avatar benmathews commented on May 18, 2024

I'm getting the same result as before with 0.4.0.

$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
go: downloading github.com/bwplotka/bingo v0.4.0
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo
Error: get command failed: get: bingo.mod: getting github.com/bwplotka/bingo: install: go: github.com/bwplotka/[email protected]: missing go.sum entry; to add it:
	go mod download github.com/bwplotka/bingo
: exit 1
$ go mod download github.com/bwplotka/bingo
go mod download: module github.com/bwplotka/bingo: not a known dependency

from bingo.

benmathews avatar benmathews commented on May 18, 2024

However, if I cp from the installed location to where bingo is expecting it to be then it works.

$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
$ bingo get -l github.com/bwplotka/bingo
bash: /home/ben/.gvm/pkgsets/go1.16.2/global/bin/bingo: No such file or directory
$ cp ~/go/bin/bingo /home/ben/.gvm/pkgsets/go1.16.2/global/bin/bingo
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo

from bingo.

bwplotka avatar bwplotka commented on May 18, 2024

Thanks, will add your info to new issue #88 to track it (:

from bingo.

bwplotka avatar bwplotka commented on May 18, 2024

It should be now resolved, including the documentation update to add -mod=mod option to Go build. Thanks!

from bingo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.