Comments (6)
Hi we fixed this in recent release, please check 🤗
https://github.com/bwplotka/bingo/releases/tag/v0.4.0
Your suggested changes would work, but there are some edge cases that had to be fixed too. Thanks!
from bingo.
This issue appears to be because the go list
command requires the go.sum
file to exist in go 1.16. To validate this I created a local hack that runs go download
(with the modfile variable) to populate the go.sum
prior to list being run. After this change all of the tests passed and it appeared to function correctly again.
--- a/get.go
+++ b/get.go
@@ -580,6 +580,10 @@ func install(runnable runner.Runnable, name string, link bool, pkg *bingo.Packag
return errors.Wrap(err, pkg.String())
}
+ if err := runnable.Download(runner.NoUpdatePolicy); err != nil {
+ return err
+ }
+
// Check if path is pointing to non-buildable package. Fail it is non-buildable. Hacky!
if listOutput, err := runnable.List(runner.NoUpdatePolicy, "-f={{.Name}}", pkg.Path()); err != nil {
return err
--- a/pkg/runner/runner.go
+++ b/pkg/runner/runner.go
@@ -80,6 +80,7 @@ var cmdsSupportingModFileArg = map[string]struct{}{
"install": {},
"list": {},
"build": {},
+ "download": {},
}
func (r *Runner) execGo(ctx context.Context, output io.Writer, cd string, modFile string, args ...string) error {
@@ -121,6 +122,7 @@ func (r *Runner) exec(ctx context.Context, output io.Writer, cd string, command
}
type Runnable interface {
+ Download(update GetUpdatePolicy, args ...string) error
List(update GetUpdatePolicy, args ...string) (string, error)
GetD(update GetUpdatePolicy, packages ...string) (string, error)
Build(pkg, out string) error
@@ -176,6 +178,19 @@ func (r *runnable) List(update GetUpdatePolicy, args ...string) (string, error)
return strings.Trim(out.String(), "\n"), nil
}
+// List runs `go list` against separate go modules files if any.
+func (r *runnable) Download(update GetUpdatePolicy, args ...string) error {
+ a := []string{"mod", "download"}
+ if update != NoUpdatePolicy {
+ a = append(a, string(update))
+ }
+ out := &bytes.Buffer{}
+ if err := r.r.execGo(r.ctx, out, r.dir, r.modFile, append(a, args...)...); err != nil {
+ return errors.Wrap(err, out.String())
+ }
+ return nil
+}
+
// GoEnv runs `go env` with given args.
func (r *runnable) GoEnv(args ...string) (string, error) {
out := &bytes.Buffer{}
from bingo.
I'm getting the same result as before with 0.4.0.
$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
go: downloading github.com/bwplotka/bingo v0.4.0
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo
Error: get command failed: get: bingo.mod: getting github.com/bwplotka/bingo: install: go: github.com/bwplotka/[email protected]: missing go.sum entry; to add it:
go mod download github.com/bwplotka/bingo
: exit 1
$ go mod download github.com/bwplotka/bingo
go mod download: module github.com/bwplotka/bingo: not a known dependency
from bingo.
However, if I cp from the installed location to where bingo is expecting it to be then it works.
$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
$ bingo get -l github.com/bwplotka/bingo
bash: /home/ben/.gvm/pkgsets/go1.16.2/global/bin/bingo: No such file or directory
$ cp ~/go/bin/bingo /home/ben/.gvm/pkgsets/go1.16.2/global/bin/bingo
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo
from bingo.
Thanks, will add your info to new issue #88 to track it (:
from bingo.
It should be now resolved, including the documentation update to add -mod=mod
option to Go build. Thanks!
from bingo.
Related Issues (20)
- List by package fail when list by binary name works HOT 1
- Add support for pinning and building forks
- bingo get does not update {package}.mod go version HOT 3
- Fix docs: go get is not installing things anymore.
- Failing to pin `staticcheck` HOT 3
- Failed to pin gomplate
- How to delete pkg? HOT 2
- Add back error cases tests.
- Bingo get fails complaining go1.18+ required which is already the case HOT 7
- Command line refactoring provides friendly prompts HOT 4
- bingo get fails on Windows: bingo.tmp.mod is being used by another process HOT 1
- "Predeclared any required go1.18 or later (-lang was set to go1.16) HOT 3
- go get succeeds but bingo fails for mockgen and golangcli-lint HOT 3
- Parsing of devel Go version fails HOT 1
- User Survey in an issue: Anything we should change for 1.0? HOT 2
- Command for updating all deps at once to latest
- Some tools are not built using go get HOT 2
- Fix ./bingo/README.md: variables.go was never supported. HOT 3
- Bug: Go 1.21.0 HOT 8
- Fails to install package with local `replace` directives and multiple modules HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bingo.