Comments (4)
minimally we need to quote more. ex this:
--- a/.bingo/Variables.mk
+++ b/.bingo/Variables.mk
@@ -21,23 +21,23 @@ GOIMPORTS := $(GOBIN)/goimports-v0.1.2
$(GOIMPORTS): $(BINGO_DIR)/goimports.mod
@# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
@echo "(re)installing $(GOBIN)/goimports-v0.1.2"
- @cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=goimports.mod -o=$(GOBIN)/goimports-v0.1.2 "golang.org/x/tools/cmd/goimports"
+ @cd "$(BINGO_DIR)" && "$(GO)" build -mod=mod -modfile=goimports.mod -o="$(GOBIN)/goimports-v0.1.2" "golang.org/x/tools/cmd/goimports"
from bingo.
I think spaces just won't work. there are a bunch of reasons why. windows would only work if you can use non-spaces for both go and the checked out project
from bingo.
one main issue is that go env GOPATH
comes out like `c:...'
The result is this is ambiguous and fails
GOBIN ?= $(firstword $(subst :, ,${GOPATH}))/bin
from bingo.
This seems to work around things well enough in git bash assuming you have go installed in a non-spaced directory such as you'd get using https://github.com/travis-ci/gimme
--- a/.bingo/Variables.mk
+++ b/.bingo/Variables.mk
@@ -2,7 +2,9 @@
# All tools are designed to be build inside $GOBIN.
BINGO_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
GOPATH ?= $(shell go env GOPATH)
-GOBIN ?= $(firstword $(subst :, ,${GOPATH}))/bin
+# This handles translation for Windows, but only in cygwin or similar environments
+PATHSEP := $(if $(COMSPEC),;,:)
+GOBIN ?= $(firstword $(subst $(PATHSEP), ,$(subst \,/,${GOPATH})))/bin
GO ?= $(shell which go)
from bingo.
Related Issues (20)
- List by package fail when list by binary name works HOT 1
- Add support for pinning and building forks
- bingo get does not update {package}.mod go version HOT 3
- Fix docs: go get is not installing things anymore.
- Failing to pin `staticcheck` HOT 3
- Failed to pin gomplate
- How to delete pkg? HOT 2
- Add back error cases tests.
- Bingo get fails complaining go1.18+ required which is already the case HOT 7
- Command line refactoring provides friendly prompts HOT 4
- bingo get fails on Windows: bingo.tmp.mod is being used by another process HOT 1
- "Predeclared any required go1.18 or later (-lang was set to go1.16) HOT 3
- go get succeeds but bingo fails for mockgen and golangcli-lint HOT 3
- Parsing of devel Go version fails HOT 1
- User Survey in an issue: Anything we should change for 1.0? HOT 2
- Command for updating all deps at once to latest
- Some tools are not built using go get HOT 2
- Fix ./bingo/README.md: variables.go was never supported. HOT 3
- Bug: Go 1.21.0 HOT 8
- Fails to install package with local `replace` directives and multiple modules HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bingo.