Giter Club home page Giter Club logo

Comments (6)

bvaughn avatar bvaughn commented on May 6, 2024

Hey @epicbagel. Thanks for sharing your thoughts.

I shied away from using Bootstrap it's pretty opinionated- which can be great but the past couple of places I've worked haven't been a fan of its default styling and so we've steered clear. (It can be a hassle to reset parts of Bootstrap's styling.) I didn't want to force people to rely on Bootstrap unnecessarily.

I did avoid any kind of nasty inline styling so that folks could choose to import my stylesheets or write their own. (I mentioned this briefly in the template overrides section). I also include pre-compiled styles in the dist folder of course, so you don't have to fit Stylus (or Sass) into your pipeline just to compile formFor's styles.

That being said, I'd be open to providing a secondary set of stylesheets that build on top of plain, vanilla Bootstrap styles- so that Bootstrap users like yourself could just include them instead.

from angular-form-for.

epicbagel avatar epicbagel commented on May 6, 2024

One suggestion would be to use Bootstrap's markup by default, so people hook into that out the box. The styl files you've included could then just be migrated to hook into the bootstrap css names and be included when people don't have or want bootstrap?

from angular-form-for.

bvaughn avatar bvaughn commented on May 6, 2024

That's a good suggestion. Let me address that in a point release. :)
Thanks!

from angular-form-for.

bvaughn avatar bvaughn commented on May 6, 2024

Hi again @epicbagel! Just writing to let you know that your suggestion has been implemented as part of Release 1.1.0.

Here's a Plnkr to let you compare Bootstrap-only styles vs formFor custom styles:
http://plnkr.co/edit/jY8TC8xbMdK5dBJMResL?p=preview

Thanks again for the suggestion!

from angular-form-for.

epicbagel avatar epicbagel commented on May 6, 2024

@bvaughn amazing, I think it will certainly help add traction to the project if people can drop it in without hooking in manual styles. Will be using this today on a prototype so will feedback with suggestions.

It may be worth updating the docs to list bootstrap is supported out the box or you can use custom styling.

from angular-form-for.

bvaughn avatar bvaughn commented on May 6, 2024

Good suggestion. I've updated the wiki this morning.

I'll check into your other issue sometime this afternoon. :)

from angular-form-for.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.