Comments (6)
Hey @epicbagel. Thanks for sharing your thoughts.
I shied away from using Bootstrap it's pretty opinionated- which can be great but the past couple of places I've worked haven't been a fan of its default styling and so we've steered clear. (It can be a hassle to reset parts of Bootstrap's styling.) I didn't want to force people to rely on Bootstrap unnecessarily.
I did avoid any kind of nasty inline styling so that folks could choose to import my stylesheets or write their own. (I mentioned this briefly in the template overrides section). I also include pre-compiled styles in the dist folder of course, so you don't have to fit Stylus (or Sass) into your pipeline just to compile formFor's styles.
That being said, I'd be open to providing a secondary set of stylesheets that build on top of plain, vanilla Bootstrap styles- so that Bootstrap users like yourself could just include them instead.
from angular-form-for.
One suggestion would be to use Bootstrap's markup by default, so people hook into that out the box. The styl files you've included could then just be migrated to hook into the bootstrap css names and be included when people don't have or want bootstrap?
from angular-form-for.
That's a good suggestion. Let me address that in a point release. :)
Thanks!
from angular-form-for.
Hi again @epicbagel! Just writing to let you know that your suggestion has been implemented as part of Release 1.1.0.
Here's a Plnkr to let you compare Bootstrap-only styles vs formFor custom styles:
http://plnkr.co/edit/jY8TC8xbMdK5dBJMResL?p=preview
Thanks again for the suggestion!
from angular-form-for.
@bvaughn amazing, I think it will certainly help add traction to the project if people can drop it in without hooking in manual styles. Will be using this today on a prototype so will feedback with suggestions.
It may be worth updating the docs to list bootstrap is supported out the box or you can use custom styling.
from angular-form-for.
Good suggestion. I've updated the wiki this morning.
I'll check into your other issue sometime this afternoon. :)
from angular-form-for.
Related Issues (20)
- Can i validate HTML or other controls using Form-for HOT 21
- Form is submitted when required checkboxes are not checked HOT 8
- Feature request: never validate not-required blank/empty/unchecked inputs HOT 4
- text-field should support input filters HOT 9
- No option to add multiple custom rules to the same field HOT 4
- Checkbox Fix Release HOT 1
- Problem with latest release HOT 9
- Formatting - Select-field HOT 2
- Enable number fields HOT 6
- checkboxField change event does not fire HOT 1
- increment validation HOT 4
- Minimum/maximum rule doesn't work when number is zero HOT 9
- SelectField auto selects the last option initially HOT 6
- Plans for Angular 2? HOT 2
- Support for asynchronous schemas HOT 2
- JSON Schema support HOT 1
- Add support for latest angular-material version HOT 3
- TypeError: Cannot read property 'unwatchers' of undefined HOT 4
- The homepage is dead HOT 1
- Dynamically change validationRules depending on submit action
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-form-for.