Memory leak on save? about buzztrax HOT 5 CLOSED

Does valgrind show one? What are you seeing and is in in you rPR with the clone?

from buzztrax.

Apologies for the lack of detail here and thanks for the reminder to run valgrind. Yes, valgrind was reporting messages like the following:

==45127== 9,025 (120 direct, 8,905 indirect) bytes in 1 blocks are definitely lost in loss record 29,620 of 29,826
==45127== at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==45127== by 0x5EA0DDA: xmlNewText (in /usr/lib/x86_64-linux-gnu/libxml2.so.2.9.14)
==45127== by 0x5EA1300: xmlNewProp (in /usr/lib/x86_64-linux-gnu/libxml2.so.2.9.14)
==45127== by 0x48917B3: bt_sequence_persistence_save (sequence.c:1379)
==45127== by 0x488C9CA: bt_persistence_save (persistence.c:189)
==45127== by 0x48A8EB4: bt_song_persistence_save (song.c:1427)
==45127== by 0x488C9CA: bt_persistence_save (persistence.c:189)
==45127== by 0x48B0FF4: bt_song_io_native_xml_save (song-io-native-xml.c:107)
==45127== by 0x48AFA37: bt_song_io_save (song-io.c:504)
==45127== by 0x12D43A: bt_edit_application_save_song (edit-application.c:555)
==45127== by 0x132624: bt_main_window_save_song_as (main-window.c:990)
==45127== by 0x133DCD: on_menu_saveas_activate (main-menu.c:132)

I believe I've fixed it here: dlbeswick@0d5acf4

I think it should be fine to ultimately go in with the machine clone feature, please let me know if you'd like it before then.

from buzztrax.

That makes sense. I think we can merge both together.

from buzztrax.

This we can now close, right?

from buzztrax.

Yes we can, thank you.

from buzztrax.