approaching 1.0 about tabwriter HOT 4 CLOSED

It seems a more idiomatic name for unwrap might be into_inner. Also is there value in it not flushing automatically?

from tabwriter.

into_inner is probably better, yeah.

I'm not sure what the use case is for it to not flush automatically. The idea with flushing automatically is to at least try and not buffer the entire contents into memory at once. In fact, this is a large part of the complexity of this library.

from tabwriter.

Sorry for not being clear enough, I mean the unwrap docs say it won't flush (a possible footgun) but is there a good reason for that?

from tabwriter.

Oooo! Right. Given that the analogous method on BufWriter flushes the buffer, I think tabwriter should probably do the same. Thanks so much for bringing this up, I probably would have completely missed it otherwise!

from tabwriter.