issue with target_feature in Conditional Compilation Tags about aho-corasick HOT 3 CLOSED

No that would be very bad. We specifically want to detect whether features like avx2 are enabled at runtime. We absolutely do not want to compile assuming avx2. If we did that, most users wouldn't benefit from it because they would 1) have to build their own software and 2) often install binaries built for them that are portable. That is, they work even when avx2 isn't available.

See: https://doc.rust-lang.org/std/arch/index.html#dynamic-cpu-feature-detection

from aho-corasick.

We do include sse2 because it is supposed to always be available for x86-64. But I'm practice, the OS can choose not to support the necessary registers during context switching. So we do require sse2 and avoid dealing with anything super exotic.

from aho-corasick.

This absolutely makes sense. Thank you for the insights!

from aho-corasick.