Comments (8)
Thanks! Good Suggestion.
There is a rate limit of 1200 requests by minute (10000k rows by second), but the app is not requesting in parallel (for now) so it is much slower, so we are fine.
from binance-downloader.
One possible implementation for this is the following:
Turn the --symbol SYMBOL, -s SYMBOL
parameter optional and then create another parameter also optional --quantity QUANTITY, -q QUANTITY
that gets the total number of coins (default 1) and then get the first QUANTITY symbols on this endpoint https://api.binance.com/api/v1/ticker/24hr
from binance-downloader.
This one is also a good issue @santoshyadav198613
Let me know if you are up for it ;)
from binance-downloader.
Hi @samuelhei,
How about we specify what symbols we want instead of quantifying?
So we could use --symbols Symbol1 Symbol2
and the default would be the same.
Another question:
with multiple symbols, we will have multiple files, right?
or we should put all symbols in one single file?
for me, the first option is the right answer.
What do you think about?
from binance-downloader.
We can separate by a comma. Check the similar script.
parser.add_argument("-p", "--pairs", action="store", dest="pairs", help="Pair(s) to download (separated by comma).", default="all")
...
pairs = list(all_currencies.keys()) if args.pairs == "all" else args.pairs.split(',')
...
for pair in sorted(pairs):
from binance-downloader.
with multiple symbols, we will have multiple files, right?
Yes, @anderson89marques different symbols we can save in different files.
We can separate by a comma. Check the similar script.
Good idea @kenorb, I will check out the script
from binance-downloader.
I just used bash for now, save below as a .sh file (including the done on the bottom), then run
bash filename.sh
in command line.
#!/bin/bash
CoinList=("BTCUSDT ETHUSDT LTCUSDT BNBUSDT NEOUSDT ETHBTC LTCBTC BNBBTC EOSBTC")
Start="2018/01/01"
End="2018/01/02"
Output="./binance/train/timestamp_symbol_interval"
for coin in $CoinList
do kline-binance --start $Start --end $End $coin 1m
done
from binance-downloader.
Hello,
at the first it's good utility. thanks for you effort to build.
I need help to add new columns into the csv files output by symbol and interval flag like the below example:
OpenTime,Open,High,Low,Close,Volume,CloseTime,qav,numTrades,tbbav,tbqav,ignore,++symbol,interval
Thank you in advance.
from binance-downloader.
Related Issues (10)
- error trying to run the requirements HOT 2
- db.py the csv writerows() puts EXTRA newline after each row HOT 1
- IndexError: list index out of range HOT 3
- KeyError: 'limit' HOT 2
- 0%: download finished succesfully HOT 3
- The README.md is not in english HOT 1
- Add progress bar HOT 2
- Create a data validation from downloaded data HOT 1
- Optimize processing for large requests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binance-downloader.