Python 3 Support about 4xidraw HOT 13 CLOSED

Sure, shoot me a pull request and I'll be right on it.

from 4xidraw.

PR is now in at #14 - let me know if there's any questions. I've managed to fix all the deprecation warnings on the test svgs I've been printing, so it now runs cleanly without popping up any messages at the end.

from 4xidraw.

I see you merged #14 - just letting you know I'm going to have another PR soon - I'm trying to work my way through as many examples as I can to hit code paths not exercised by AxiDraw_First.svg, now my 4xidraw build quality is improved enough to run more complex stuff.

One example at "examples/test and cal/SmalltestPattern.svg" has thrown up 2 more deprecation warnings and a change in behaviour that crashes when running Inkscape 1.x so I'll put a PR in once I've got that SVG working properly.

from 4xidraw.

I've now got SmalltestPattern.svg working so have raised a PR at #15 for the changes required.

As well as the compatibility shims to cover code paths used by that svg, the PR includes an improvement to Python importing that should better separate out the Python 2 and Python 3 code paths from impacting each other. Let me know if there's anything you would like to discuss or change (my workplace has code review on every commit so I'm used to it!)

from 4xidraw.

Thanks a lot for the patches, haven't used my own 4xiDraw for a long time (there was no MiniMakerFaire this year due to COVID, otherwise I would probably have used it there).

from 4xidraw.

Happy to help out, I currently do a reasonable amount of Python coding in the day job so I'm as well placed to do the patches as anyone. I will probably upgrade to a full-on Axidraw at some point - but I figure I should pay my dues first and figure out how the engineering tradeoffs go, rather than just splashing out the money!

from 4xidraw.

from 4xidraw.

Interesting - I didn't know that... yes they have their own protocol as per https://evil-mad.github.io/EggBot/ebb.html#syntax - wonder why... I guess it helps them optimise for their hardware?

from 4xidraw.

@MatthewJohnMorris It is my understanding EBB moves are only at a constant speed, thus any acceleration has to be simulated by chaining moves with increasing speeds, which requires multiple commands for a single straight-line move if accel/decel is needed.

I reckon they use EBB as it was used for previous projects.

from 4xidraw.

Thanks @misan, that's interesting, I will have a look at that at some point...

@bullestock I've raised snother PR #16 - this is to take care of a deprecation warning and clear up handling of pixel extents. I seem to be able to run pretty much anything else now.

One question - I see the "distance travelled" for pen up/down shown when "reportTime=True" isn't actually hooked up to any calcualtion at the moment, so always returns zero. Would there be any interest in my adding support for that?

from 4xidraw.

One question - I see the "distance travelled" for pen up/down shown when "reportTime=True" isn't actually hooked up to any calcualtion at the moment, so always returns zero. Would there be any interest in my adding support for that?

It's not something that I have wished for personally, but if you're bored, go ahead :-)

from 4xidraw.

It's not something that I have wished for personally, but if you're bored, go ahead :-)

I'll see how bored I get with the family jigsaw puzzles at home :)

from 4xidraw.

I think anything else I work on at this point will be an enhancement rather than Python3 stuff, so may as well close the issue

from 4xidraw.