Comments (10)
欢迎提交PR,非常感谢~
from quickjs-go.
已提交,另外开发时遇到过将context中的集合对象调用js中合法的方法时,比如 map 对象调用keys方法,出现数组范围异常的提示,请问一下有思路吗?
from quickjs-go.
很棒的PR,我提一点优化建议,请到PR中查阅。
另外,关于“数组范围异常的提示”问题,能否给个重现的代码?
from quickjs-go.
很棒的PR,我提一点优化建议,请到PR中查阅。
另外,关于“数组范围异常的提示”问题,能否给个重现的代码?
quickjs_test.go文件内添加:
`
func TestMapGetArrayError(t *testing.T) {
rt := quickjs.NewRuntime()
defer rt.Close()
ctx := rt.NewContext()
defer ctx.Close()
test := ctx.Map()
defer test.Free()
for i := int64(0); i < 3; i++ {
test.Put(ctx.Int64(i), ctx.String(fmt.Sprintf("test %d", i)))
require.True(t, test.Has(ctx.Int64(i)))
//testValue.Free()
}
value := test.ToValue().Call("keys")
fmt.Println(value.String())
value.Free()
}
`
执行测试代码可以复现,array、set、map里的其他部分方法调用都会出这个问题,目前看只要是涉及到获取新数组的,都是这样
至于PR中的意见,我没有看到,你也可以在这里提,然后我看着修改
from quickjs-go.
抱歉,应该是我的review 没有提交,可以试下能否看到。此外,修改建议我也贴在下方:
context.go 中
1、line 124
val := Value{ctx: ctx, ref: C.JS_NewArray(ctx.ref)}
建议改为:
val := Value{ctx: ctx, ref: C.JS_NewArray(ctx.ref)}
2、line 130
val := ctx.eval(
new Map();)
建议改为:
ctor := ctx.Globals().Get("Map")
defer ctor.Free()
val := Value{ctx: ctx, ref: C.JS_CallConstructor(ctx.ref, ctor.ref, 0, nil)}
3、line 136
val := ctx.eval(
new Set();)
建议改为:
ctor := ctx.Globals().Get("Set")
defer ctor.Free()
val := Value{ctx: ctx, ref: C.JS_CallConstructor(ctx.ref, ctor.ref, 0, nil)}
from quickjs-go.
非常感谢您的指正,PR已提交,您提供的代码让我对之后如何操作class有了一个大概的方向,感谢
from quickjs-go.
#39 已合并。
已重现关于“数组范围异常的提示”问题已重现,可能需要跟踪下quickjs c代码中是否实现了keys 方法,等我有时间研究下,所以此issue 仍然保持打开
from quickjs-go.
不只是map的keys方法有问题,array的unshift方法我记得也是有问题的,可能不单止是底层是否实现keys方法的问题
from quickjs-go.
确认为 js_call 调用的一个bug,当参数为0时,数组越界。
已修复于 f08c12b
请验证~
from quickjs-go.
确认为 js_call 调用的一个bug,当参数为0时,数组越界。 已修复于 f08c12b
请验证~
已经简单验证了,暂时没看到问题
from quickjs-go.
Related Issues (11)
- 'setTimeout' is not defined HOT 2
- 是否有计划实现 `JS_NewArrayBuffer` `JS_NewArrayBufferCopy` 等相关接口绑定 HOT 3
- import error : SyntaxError: expecting '(' HOT 3
- Support for JS_SetInterruptHandler HOT 2
- 速度怎么样? HOT 1
- 增加debug分支并更改cgo构建目标以用于支持debug? HOT 1
- NewLoop中make的chan一直不会释放,即使runtime free了也不会,占用内存比较多 HOT 6
- Build failing when building on windows 11 HOT 5
- 构建失败 HOT 4
- Is it possible to write a file? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickjs-go.