Giter Club home page Giter Club logo

Comments (5)

lox avatar lox commented on September 1, 2024

Unfortunately there is no interpolation or shell expansion that would expand that glob. We are at the mercy of whatever glob expansion shellcheck or that docker image provides.

from docker-buildkite-plugin.

huonw avatar huonw commented on September 1, 2024

I'm not sure I understand: bash does expand that **/*.sh glob for me. Are you saying that the plugin doesn't have a way to do that? If so, I'm looking for the plugin to support an option to expand globs, for images where's there's no other option, e.g. AFAICT, that image doesn't even contain a shell so the only way to expand globs is to do it externally. It's true that I could do it without using this plugin, but doing it declaratively is much nicer.

Hypothetically, the plugin could have an option expand_command_globs: true that passes all the command values through some expand_glob function to go from **/*.sh to, say, foo/bar.sh foo/baz/qux.sh.

from docker-buildkite-plugin.

toolmantim avatar toolmantim commented on September 1, 2024

I see your conundrum there. Have you checked out https://github.com/buildkite-plugins/shellcheck-buildkite-plugin @huonw? Perhaps we should choose a different example for the readme here.

Out of interest… how did you end here at this plugin, instead the spellcheck one? Perhaps that's something we should look at.

from docker-buildkite-plugin.

huonw avatar huonw commented on September 1, 2024

Have you checked out https://github.com/buildkite-plugins/shellcheck-buildkite-plugin @huonw?

Thanks! That solves my specific issue in the best way!

Out of interesting… how did you end here at this plugin, instead the spellcheck one? Perhaps that's something we should look at.

We're using the docker plugin for our other steps (with custom docker images, so no more specific plugin for them), and I didn't even think to look for a different plugin.

from docker-buildkite-plugin.

toolmantim avatar toolmantim commented on September 1, 2024

Thanks @huonw! Good to hear. We'll find a better readme example…

from docker-buildkite-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.