Giter Club home page Giter Club logo

Comments (1)

EdSchouten avatar EdSchouten commented on June 7, 2024

Hi @YngveNPettersen,

This is an interesting issue you raise here. This incompatibility/annoyance is due to a small protocol change that has happened over the last year. It used to be the case that the Action Cache was only supposed to hold ActionResult entries for actions that completed successfully (exit_code == 0).

At some point, people started to discuss whether this restriction was smart. There are use cases outside of Bazel/Goma/... in which you do want such failures to be cached. The Remote Execution protocol also doesn't document such a restriction in the first place, meaning that Bazel was simply being too strict. Links:

bazelbuild/bazel#7137
https://gitlab.com/BuildGrid/buildgrid/issues/151
https://groups.google.com/forum/#!msg/bazel-discuss/kuRjYFfhDd0/y-Y5nfN1EAAJ

This eventually got resolved by patching up Bazel to allow and ignore such entries:

bazelbuild/bazel@62f5458

It looks like Goma needs to be patched up similarly. Feel free to send a PR to the Goma developers, linking to this issue. I will close this issue for the time being, because I don't think there is anything actionable on the Buildbarn side.

from bb-remote-execution.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.