Problems Updating Runner to Latest Bazel about bb-remote-execution HOT 6 CLOSED

Thanks for giving more detail there!

• Don't stop when cleaning up something fails.

I'd disagree with this. I think it should fail though perhaps with a clearer message.

from bb-remote-execution.

The folder that fails to be cleaned up is /run/lock, which contains a subsys folder (IIRC) owned by root. It would be good to know why we need to cleanup those folders as it doesn't look like they are ever used when building things.

Could we workaround this issue in a different way?

• Cleanup a subfolder instead of these (if we are actually using them, and we can decide where the temp files go)
• Cleanup only folders we can actually delete (owned by the runner user)
• Don't stop when cleaning up something fails.

from bb-remote-execution.

I also had such failures due to a root-owned file/directory under /tmp in my runner container. The file was related to sysdig in Kubernetes. Skipping deletion of files owned by other users seems sensible.

And definitely need better error messages. Locally I modified to return util.StatusWrap(err, name) in RemoveAllChildren

from bb-remote-execution.

I believe the initial problem has been solved in a5be3f6. Now the question is, how to indeed deal with failing cleanup.

from bb-remote-execution.

Mind if I ask why the cleanup is needed? Are we expecting builds to put files in those locations?

from bb-remote-execution.

The runner image has been updated in the meantime. Let's mark this as closed.

from bb-remote-execution.