Wrong namespace of exception handler about bugsnag-laravel HOT 5 CLOSED

Yeah, this is for sure an issue, and likely going to be incredibly difficult to fix.

from bugsnag-laravel.

I was able to thwart this issue by doing the following:

1. NOT include the BugsnagLaravelServiceProvider
2. Using php artisan make:provider BugsnagServiceProvider
3. Editing this provider to include the same register() method as the shipped provider.
4. Updating my App\Exceptions\Handler (except it's not App), and replacing that report() method with the same report() method as the shipped handler.

from bugsnag-laravel.

Also having this issue. Should bugsnag extend Illuminate\Foundation\Exceptions\Handler instead?

from bugsnag-laravel.

An alt to doing what adamgoose suggested.

http://laravel.com/docs/5.0/errors#handling-errors

We can temp put this in the main handler:

app/Exceptions/Handler.php

public function report(Exception $e)
{
  $shouldReport = true;

  foreach ($this->dontReport as $type)
  {
      if ($e instanceof $type)
      {
          $shouldReport = false;
      }
  }

  if ($shouldReport) 
  {
     $bugsnag = \App::make('bugsnag');
     $bugsnag->notifyException($e);
  }

  return parent::report($e);
}

We need to override the singleton they bind in their service provider but keep all the rest of the functionality.

So then make your own exception service provider and place it right after the bugsnag one with this in it:

config/app.php

'providers' => ...
  'Bugsnag\BugsnagLaravel\BugsnagLaravelServiceProvider',
  'MyNamespace\Providers\ExceptionServiceProvider',

app/Providers/ExceptionServiceProvider.php

<?php namespace MyNamespace\Providers;

use Illuminate\Support\ServiceProvider;

class ExceptionServiceProvider extends ServiceProvider {

  public function boot()
  {
    $this->app->singleton('Illuminate\Contracts\Debug\ExceptionHandler', 'MyNamespace\Exceptions\Handler');
  }

  public function register(){}
}

from bugsnag-laravel.

I'd love feedback on #40 — would that work for everyone?

from bugsnag-laravel.