Giter Club home page Giter Club logo

Comments (3)

higebu avatar higebu commented on June 14, 2024 1

Hi @Kryan90,
I've created a pull request (#99). I hadn't seen this issue when I made the PR. Having now reviewed the request, I believe my PR might align with what you're looking for. Could you please take a look and let me know if it matches the PR you had in mind? I'm open to feedback and any adjustments needed.
My proposed spec is here: https://github.com/higebu/protovalidate/blob/9f4f80cc1119ecedf5214af4aec3c189acd52902/proto/protovalidate/buf/validate/validate.proto#L2821-L2918
Thank you!

from protovalidate.

Kryan90 avatar Kryan90 commented on June 14, 2024 1

Hi @Kryan90, I've created a pull request (#99). I hadn't seen this issue when I made the PR. Having now reviewed the request, I believe my PR might align with what you're looking for. Could you please take a look and let me know if it matches the PR you had in mind? I'm open to feedback and any adjustments needed. My proposed spec is here: https://github.com/higebu/protovalidate/blob/9f4f80cc1119ecedf5214af4aec3c189acd52902/proto/protovalidate/buf/validate/validate.proto#L2821-L2918 Thank you!

This is functionally exactly what I had been looking for, thank you! The naming is slightly different, but I think ip_with_prefixlen is probably a more accurate descriptor anyway

from protovalidate.

elliotmjackson avatar elliotmjackson commented on June 14, 2024

Thank you for the comprehensive feature request! The proposed implementations, (buf.validate.field).string.cidr, .string.cidrv4, and .string.cidrv6 seem in line with the existing structure and should provide a clear and consistent validation approach.

Your willingness to contribute to the implementation is much appreciated. We'd be happy to guide you on how implementations are done. Leveraging the existing functions to make this a pure CEL constraint is a compelling idea. If we can achieve that, it'd be ideal as it would remove the need to complete language-specific implementations.

from protovalidate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.