Comments (3)
Hi @Kryan90,
I've created a pull request (#99). I hadn't seen this issue when I made the PR. Having now reviewed the request, I believe my PR might align with what you're looking for. Could you please take a look and let me know if it matches the PR you had in mind? I'm open to feedback and any adjustments needed.
My proposed spec is here: https://github.com/higebu/protovalidate/blob/9f4f80cc1119ecedf5214af4aec3c189acd52902/proto/protovalidate/buf/validate/validate.proto#L2821-L2918
Thank you!
from protovalidate.
Hi @Kryan90, I've created a pull request (#99). I hadn't seen this issue when I made the PR. Having now reviewed the request, I believe my PR might align with what you're looking for. Could you please take a look and let me know if it matches the PR you had in mind? I'm open to feedback and any adjustments needed. My proposed spec is here: https://github.com/higebu/protovalidate/blob/9f4f80cc1119ecedf5214af4aec3c189acd52902/proto/protovalidate/buf/validate/validate.proto#L2821-L2918 Thank you!
This is functionally exactly what I had been looking for, thank you! The naming is slightly different, but I think ip_with_prefixlen
is probably a more accurate descriptor anyway
from protovalidate.
Thank you for the comprehensive feature request! The proposed implementations, (buf.validate.field).string.cidr
, .string.cidrv4
, and .string.cidrv6
seem in line with the existing structure and should provide a clear and consistent validation approach.
Your willingness to contribute to the implementation is much appreciated. We'd be happy to guide you on how implementations are done. Leveraging the existing functions to make this a pure CEL constraint is a compelling idea. If we can achieve that, it'd be ideal as it would remove the need to complete language-specific implementations.
from protovalidate.
Related Issues (20)
- Add package documentation for Protobuf packages
- [Feature Request] PHP Support
- [Feature Request] Ruby Support
- [Question] Deprecated field validation HOT 1
- [Question] I can't generate a validator with buf, is the plugin used by the buf.gen.yaml file incorrect? HOT 1
- Protoc does not generate validation code [BUG] HOT 1
- [Feature Request] Have URI validations for string but also allow empty HOT 1
- [Feature Request]: Add wellknown regex for URL encoded parameters HOT 1
- Cannot resolve import HOT 1
- [Question] Migration from protoc-gen-validate to protovalidate HOT 2
- [Feature Request] Add to scalapb common protos HOT 3
- [Question] Carrying Patches from protoc-gen-validate HOT 1
- How do you use protovalidate on grpc-gateway? HOT 2
- [Feature Request] How to replace error messages in standard constraints? HOT 1
- [BUG] Regex in CEL with non-capturing group issue HOT 1
- [BUG] migrate: tmp on different partition than target [invalid cross-device link] HOT 1
- [BUG] migration tool: repeated strings with ignore_empty doesn't work HOT 2
- Add access to custom options (of host messages).
- [BUG] Migrator uses wrong field path for string ignore HOT 1
- [Feature Request] how to do i18n? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protovalidate.