Giter Club home page Giter Club logo

Comments (10)

n1tin avatar n1tin commented on May 31, 2024 1

Will get the tooltip working first 🙂

from villain.

n1tin avatar n1tin commented on May 31, 2024

Hey! Would be interested in looking at https://github.com/bsidelinger912/react-tooltip-lite. It is used in one of the projects at my workplace and looks neater than the 'react-tooltip' lib. Also if you are fine with this I can work to raise a PR with the tooltip changes for the elements where ever you think it is required.

from villain.

btzr-io avatar btzr-io commented on May 31, 2024

@n1tin Sure, go for it 👍

from villain.

btzr-io avatar btzr-io commented on May 31, 2024

Some examples and suggestions:
https://material.io/components/tooltips/#

from villain.

btzr-io avatar btzr-io commented on May 31, 2024

@n1tin Are you still working on this ?

from villain.

n1tin avatar n1tin commented on May 31, 2024

Yes @btzr-io. I have made some changes (https://github.com/n1tin/Villain/commit/0a1179ce7456a51956533a21ba40a5a2acf7e61b) but it is not working properly in the fullscreen mode so trying to fix that.

from villain.

btzr-io avatar btzr-io commented on May 31, 2024

@n1tin Oh ok, just checking,
Well if you have any questions or need help let me know ✌️

from villain.

n1tin avatar n1tin commented on May 31, 2024

'react-tooltip-lite' lib is adding the tooltip <span> outside the App container tag so I am having to move css variables to :root. Are you okay with this or are you preferring the native ones?

from villain.

btzr-io avatar btzr-io commented on May 31, 2024

@n1tin I guess its ok to move them to :root but maybe we should add a prefix to prevent conflicts with external styles? like this:

--villain-toolbar-bg: #FFF;

Anyway don't worry about it, should be handle on a different pr unless you also want to work on that?

from villain.

n1tin avatar n1tin commented on May 31, 2024

@btzr-io Have raised #75. Have added a native tooltip one as all the libs I tried are rendering outside of the app div and it is not working in fullscreen as the main content is taking up the screen and nothing outside of it can be made visible.

from villain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.