Not compatible with angular.js v1.3.0-rc.0 sonic-boltification about angular-modal HOT 4 CLOSED

@ryanhart2 thanks for finding all that. I'm not sure the best way to fix this based on versions other than to just switch it over to use the promise. However, this would then break people using older versions of angular and it would seem to be clunky to add version detection to the directive. I wonder if the solution is to just stop supporting older 1.2 once 1.3 becomes final or if there is something more elegant?

function deactivate () {
  var deferred = $q.defer();
  if (element) {
    $animate.leave(element).then(function () {
      scope.$destroy();
      element = null;
      deferred.resolve();
    });
  } else {
    deferred.resolve();
  }
  return deferred.promise;
}

from angular-modal.

I created a fork and and a pull request which use the new signature of $animate.leave(). #30

from angular-modal.

@chrisguttandin awesome, looks good to me.

from angular-modal.

Should be fixed in v0.5

from angular-modal.