Why don't some of the `btcdb.Db` methods return an error? about btcdb HOT 6 CLOSED

For the most part, the methods that don't return an error either have the error in the returned data set or don't really have any recourse. For example, consider the FetchTxByShaList function. It returns a slice of *TxListReply which includes a field Err for each individual transaction. The intent there is you can request multiple transactions at once and some may fetch successfully while others may not.

On the other hand, take the Close function. Of the 4 implementations we have done, there really is no legitimate response to being unable to close (aside from maybe trying again, but it will almost positively fail too).

I'm not against adding errors to the interface for the others if there is a need since it would be trivial for the existing implementations that don't have an error to return can simply return nil.

from btcdb.

I didn't see error in TxListReply, nice touch.

My initial thoughts were with the ExistsSha and ExistsTxSha methods. If there is an error with the underlying database read then is it OK to just return false without repercussions?

I just dug a bit deper and notice some code comments suggest this issue might be a work in progress with the ldb driver: https://github.com/conformal/btcdb/blob/master/ldb/tx.go#L248 and https://github.com/conformal/btcdb/blob/master/ldb/block.go#L230.

from btcdb.

I've asked drahn to comment, but I suspect those should have error added.

from btcdb.

Alright, so I discussed this with drahn and he's in agreement that all of them except FetchTxByShaList and FetchUnSpentTxByShaList make sense to have error returns.

@drahn Close(), ExistsSha(), ExistsTxSha(), RollbackClose(), and Sync() all make sense to have an error return.

I will be taking care of adding these shortly.

from btcdb.

@qedus Did these changes address your concerns?

from btcdb.

@davecgh yes this completely addresses my concerns. I am also glad Close, Sync and RollbackClose also have error returns even though I agree that in almost every case no one should care about their values. Thanks!

from btcdb.