xpubkey masking via PGP about btcpayserver HOT 6 CLOSED

@austrocoin yes, actually I think .NET Core has a nice API for this kind of two step confirmation, did not had yet time to look to it though.

from btcpayserver.

This is quite a lots of feature here.

Would be nice to have, the mails are not very essential though. It is just for renewing password.
Nothing really important is sent.
IP Whitelist I think are better suited to be handled by the reverse proxy configuration. (NGINX/IIS)

from btcpayserver.

the mails are not very essential though. It is just for renewing password.
Nothing really important is sent. yes I agree .
Nginx takes care of this.. keeping it clean and simple :)

from btcpayserver.

Agree of course but I would find an additional approval mail for changing xpub not a bad thing - here is where PGP is usefull in my eyes.

from btcpayserver.

@austrocoin

deactivate accounts on X failed logins.

In my opinion, this is not a good idea since it gives anyone the ability to deactivate any account in a really easy way, something like temp ban IPv4 or /64 prefix of corresponding IPv6 after a number of failed login is a better approch.

from btcpayserver.

Closing this, if we mask the PGP itself with encryption, it can't be used in BTCPay. You brought out some good ideas, some of them like 2FA are already implemented and for #53 there's a separate issue. Feel free to re-formulate with current state of BTCPay and re-open if you have further ideas.

from btcpayserver.