Comments (19)
yes, this has been completely rewritten, but I do think it should include an acknowledgement that it started out as that. It's theseus's ship, if you fork an open source project, and rewrite every line of code, is it still the same project?
from sha.js.
@dominictarr leaving this one to you...
from sha.js.
To be honest, we could probably completely ditch that as this code has been entirely re-written...
from sha.js.
The only bits that still resemble the original are variable naming in bits like
https://github.com/crypto-browserify/sha.js/blob/master/sha1.js#L50-L54
from sha.js.
We could leave an acknowledgement, but leave the license as is? IANAL, just thinking
from sha.js.
from sha.js.
@bastien-roucaries we are not trynig to be difficult just to understand what we need to do.
from sha.js.
@bastien-roucaries are you saying we have to change the license back to the original one?
can it say "Copyright (c) 1998 - 2009, Paul Johnston & Contributors, Copyright (c) 2013-2014 sha.js contributors"?
from sha.js.
or can we put the original license in a comment at the top of the files that currently mention that author?
from sha.js.
from sha.js.
@bastien-roucaries I don't understand what this "expat" thing is, they used BSD. If you want us to fix the license can you please answer my questions above
from sha.js.
from sha.js.
MIT License (Expat)
https://www.debian.org/legal/licenses/mit
from sha.js.
Do we just change our license to BSD3?
from sha.js.
@bastien-roucaries could you please submit a PR for what exactly needs to change?
from sha.js.
ping @bastien-roucaries
from sha.js.
from sha.js.
from sha.js.
@bastien-roucaries PR? 👍
from sha.js.
Related Issues (20)
- Spelling mistake on readme HOT 5
- Tag releases HOT 1
- use standard for formatting HOT 1
- Extract hash.js for use in ripemd160 HOT 12
- Cannot find module 'graceful-fs' from '.../node_modules/sha' HOT 5
- Add npm badge
- Release tag for 2.4.2 missing HOT 2
- Bug in sha implementation (likely due to international characters) HOT 10
- Use Safe Buffer HOT 3
- Digest calculation fails for large files (greater than uint32 bits)
- Unable to resolve module `buffer` from `xxx/xxx`: Module does not exist in the module map HOT 9
- sha256stream.end HOT 1
- Angular 6 HOT 3
- bin.js requires ./browserify which does not exist HOT 1
- Project is not "pure JavaScript" as advertised. HOT 3
- New Yarn version, package.json bin causes warning HOT 4
- Test case failure while building sha.js on PowerPC64LE - ppc64le HOT 1
- Copy mid state of hash
- index.js exports overwrite exports in jest context
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sha.js.