Giter Club home page Giter Club logo

Comments (19)

dominictarr avatar dominictarr commented on August 20, 2024 2

yes, this has been completely rewritten, but I do think it should include an acknowledgement that it started out as that. It's theseus's ship, if you fork an open source project, and rewrite every line of code, is it still the same project?

from sha.js.

dcousens avatar dcousens commented on August 20, 2024 1

@dominictarr leaving this one to you...

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

To be honest, we could probably completely ditch that as this code has been entirely re-written...

from sha.js.

dominictarr avatar dominictarr commented on August 20, 2024

The only bits that still resemble the original are variable naming in bits like
https://github.com/crypto-browserify/sha.js/blob/master/sha1.js#L50-L54

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

We could leave an acknowledgement, but leave the license as is? IANAL, just thinking

from sha.js.

bastien-roucaries avatar bastien-roucaries commented on August 20, 2024

from sha.js.

dominictarr avatar dominictarr commented on August 20, 2024

@bastien-roucaries we are not trynig to be difficult just to understand what we need to do.

from sha.js.

dominictarr avatar dominictarr commented on August 20, 2024

@bastien-roucaries are you saying we have to change the license back to the original one?
can it say "Copyright (c) 1998 - 2009, Paul Johnston & Contributors, Copyright (c) 2013-2014 sha.js contributors"?

from sha.js.

dominictarr avatar dominictarr commented on August 20, 2024

or can we put the original license in a comment at the top of the files that currently mention that author?

from sha.js.

bastien-roucaries avatar bastien-roucaries commented on August 20, 2024

from sha.js.

dominictarr avatar dominictarr commented on August 20, 2024

@bastien-roucaries I don't understand what this "expat" thing is, they used BSD. If you want us to fix the license can you please answer my questions above

from sha.js.

bastien-roucaries avatar bastien-roucaries commented on August 20, 2024

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

MIT License (Expat)

https://www.debian.org/legal/licenses/mit

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

Do we just change our license to BSD3?

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

@bastien-roucaries could you please submit a PR for what exactly needs to change?

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

ping @bastien-roucaries

from sha.js.

bastien-roucaries avatar bastien-roucaries commented on August 20, 2024

from sha.js.

bastien-roucaries avatar bastien-roucaries commented on August 20, 2024

from sha.js.

dcousens avatar dcousens commented on August 20, 2024

@bastien-roucaries PR? 👍

from sha.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.