Giter Club home page Giter Club logo

Comments (3)

bengourley avatar bengourley commented on May 21, 2024

After a bit more poking around, I've tracked down the source of the inconsistency to https://github.com/substack/node-detective/blob/master/index.js#L49:

if (src.indexOf(word) == -1) return modules;

This short circuit (presumably for performance, to prevent an unnecessary esprima parse) means that sources with the string 'require' anywhere (including in a comment or within a string) will be parsed, but those that don't won't.

Calling detective on this source throws an error:

// I dont require any modules
return

This doesn't:

return

from detective.

 avatar commented on May 21, 2024

Fixed in 2.1.1.

from detective.

bengourley avatar bengourley commented on May 21, 2024

Thanks!

from detective.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.