Inmutable? about duix HOT 4 CLOSED

In my own code, I did implement a "deepFreeze" of the objects...

// Thanks to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze
function deepFreeze(object) {
    var propNames = Object.getOwnPropertyNames(object);
    for (let name of propNames) {
        let value = object[name];

        if (value && typeof value === "object") {
            deepFreeze(value);
        }
    }

    return Object.freeze(object);
}

from duix.

@jehon I just saw that we broke something with the deepEqual check.

Check this code:

const user = duix.get('user');
user.listOfSomething.push(123);
duix.set('user', user);

In line 2, we are mutating the state, so, when we do the PUSH value, now user have the 123 value. What happens here? Well... Then, we do the duix.set, but the listOfSomething already had the value, so, there is no change in the object, thus, no callback called.

The callback on duix.subscribe should receive a newValue that can be mutated with no mutating the value on the storage. it should retrieve a clone, or something like that.

How do you think we should handle it? I never used the Object.freeze approach.
Should we freeze the object before sending it to the callbacks?

from duix.

@jehon I'm working on it

from duix.

Fixed on v3.0.0

from duix.