Comments (6)
Could this be a variation of isaacs/rimraf#72?
from broccoli-plugin.
I guess it is closely related, but why does broccoli tries to delete files before printing the error?
The issue I'm facing is the lost error message.
from broccoli-plugin.
why does broccoli tries to delete files before printing the error?
Ah, I see the problem - the cleanup happens before the error is reported, so the cleanup error "wins". It's a bit tricky to change this without silently swallowing cleanup errors, or adding a bunch of extra error handling code.
I'd like to suggest that it's actually acceptable to print the cleanup error rather than the build error. If a cleanup error happens, that's so fundamental an issue that it should usually be fixed first. I realize that this is happening a lot on Windows because of isaacs/rimraf#72, but then again perhaps one could say that Broccoli is simply broken on Windows until isaacs/rimraf#72 is fixed, and this is just one of many symptoms of this brokenness.
from broccoli-plugin.
But would not additional .catch
before .finally
suffice?
from broccoli-plugin.
I've thought about this some more, and I don't think the behavior should be changed. If there's a cleanup error, then that error should be reported.
from broccoli-plugin.
Fair enough. The isaacs/rimraf#72 is painful.
from broccoli-plugin.
Related Issues (17)
- Make inputTrees immutable HOT 4
- Example code fails with TypeError: Missing `new` operator HOT 1
- Narrowing down caching failure - RFC HOT 56
- How do we handle dependencies that are not within the input tree? HOT 1
- This project appears to introduce ~239 files via itself and its deps
- better "cleanup" idea HOT 5
- HTML elements don't have closing tags
- got [object Object] for inputNodes[1] HOT 6
- [Discussion] Attaching Meta Data HOT 2
- trackInputChanges fails silently on older broccoli versions HOT 1
- builtin walkSync for this.output, this.input or `fake fs` HOT 1
- cachePath persistence. HOT 2
- Snyk shows high vulnerable issue through dependencies
- tests appear to require the internet HOT 4
- `multidep` failure on node@15
- Not working with ember-auto-import & absolute input paths HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broccoli-plugin.