Comments (1)
brminnick
commented on June 30, 2024
1
Honestly, continueOnCapturedContext shouldn't even be an option; it should always be false because ConfigureAwait only impacts the code that executes after Func<Task> _execute finishes and no code executes after _execute.
When AsyncCommand.Execute is called, it runs _execute.SafeFireAndForget
In SafeFireAndForget, there is no code that executes following the completion of the Task:
If the default was true, .NET would switch back to the calling thread after executing the Task, which, in the context of SafeFireAndForget, it would be switching back to the calling thread only to return the method finalizer, a needless context switch.
from asyncawaitbestpractices.
Related Issues (20)
- What Dotnet native directives to use with .Net Native tool chain?
- Windows 11 - Smart App Control HOT 2
- CanExecute is called only once HOT 2
- Async / Await != Multithread HOT 2
- Add SourceLink
- CanExecuteChanged doesn't fire HOT 7
- CanExecute issue HOT 2
- Error when running from signed assembly HOT 5
- Is "Sealed" necessary for AsyncCommand? HOT 2
- Execute parameter ignored HOT 3
- WinRT: Windows 8.1 SafeFireAndForget issue "No overload for method" HOT 12
- ArgumentException with Dynamic Handlers HOT 2
- Possible improvement for explicit ICommand.Execute() implementation in AsyncCommand? HOT 1
- Why's MVVMLight's message sent in vain? HOT 13
- Question: Cancellation HOT 1
- SafeFireAndForget is not safe HOT 8
- Add NuGet README
- Does RaiseCanExecuteChanged need to be called on the UI thread?
- Parameter change does not invoke CanExecuteChanged HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asyncawaitbestpractices.