Giter Club home page Giter Club logo

Comments (5)

dlockhart avatar dlockhart commented on May 31, 2024

Interesting! So I think we were being a bit intentional about only having the icon be ferrite, since the design kind of specs it out that way. What's your use case for coloured icons?

from core.

j3parker avatar j3parker commented on May 31, 2024

Just glitter. I'm switching between tier1:role-switch and tier1:close-circle to cancel it:

image

It's a bit easier to tell the two states apart with some color (but not required). If we don't want that because of design I'm fine with that!

from core.

j3parker avatar j3parker commented on May 31, 2024

Here it is, hacked with color, in case this screams "obviously wrong" :)

image

from core.

dlockhart avatar dlockhart commented on May 31, 2024

Yeah I'm pretty sure design intentionally wanted the grey icons to avoid having particular ones popping. There's also the accessibility angle, where enough contrast needs to exist between the icon colour and the hover background colour, which we can guarantee by controlling it.

I'd also worry that if we supported this, then suddenly colours set on parent elements would start bleeding into our icons everywhere, without us actually wanting it to happen. i.e.

<div style="color:pink">
    Pink text
    <d2l-icon></d2l-icon>
</div>

from core.

j3parker avatar j3parker commented on May 31, 2024

Ok, cool! Thanks for the explanation.

Ah that cascading thing is definitely not pretty.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.