Comments (8)
No rush, I was just reporting :)
from babel-plugin-flow-react-proptypes.
Fixed, thanks for reporting and trying out the plugin :-)
from babel-plugin-flow-react-proptypes.
I'm not getting an error on that code snippet. Are you getting an error with that exact code?
$ babel --presets react,stage-1,es2015 --plugins ./lib/index.js < src/__test__/fixtures/functional-component.input.js
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
var _react = require("react");
var _react2 = _interopRequireDefault(_react);
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
var ReactFunctionalComponent = function ReactFunctionalComponent(props) {
return _react2.default.createElement(
"div",
null,
props.param
);
};
exports.default = ReactFunctionalComponent;
from babel-plugin-flow-react-proptypes.
yeah. Oh so maybe related to the fact that I use babel-eslint?
from babel-plugin-flow-react-proptypes.
Oh my bad, I am getting this with my test class
/* @flow */
import React, { Element, Component } from "react"
type Props = {
onMount?: () => void,
}
type State = {
clicked: boolean,
}
class ReactClassComponent extends Component<void, Props, State> {
state: State = {
clicked: false,
};
constructor(props: Props) {
super(props)
}
componentDidMount() {
if (this.props.onMount) {
this.props.onMount()
}
}
handleClick: () => void = () => {
this.setState({ clicked: true })
};
render(): Element {
return (
<div onClick={ this.handleClick }>
{
!this.state.clicked
? "Hi"
: "Hey"
}
</div>
)
}
}
export default ReactClassComponent
from babel-plugin-flow-react-proptypes.
I see the issue. It's the onMount?: () => void,
. I'm not handling function type annotations.
I'll have it fixed in a few hours.
from babel-plugin-flow-react-proptypes.
What are the prospects for supporting functional components?
from babel-plugin-flow-react-proptypes.
@glortho moved it to a standalone issue #11.
from babel-plugin-flow-react-proptypes.
Related Issues (20)
- PropTypes are not added to class components with intersected type parameters HOT 2
- Import type - implementation guidelines? HOT 4
- Not working when module.name_mapper is used HOT 1
- transforming recompose context props. HOT 1
- Types imported with `import *` (import star) are treated as values, causing runtime error HOT 4
- Add support for $ReadOnlyArray HOT 2
- Error when union types HOT 1
- Perform escape analysis on imported types HOT 3
- Fails to check "Objects as maps"
- Identifier 'PropTypes' has already been declared HOT 2
- Example form README is not transpiled correctly HOT 2
- plugin errors when parsing "empty" types HOT 2
- Undefined variable in output when input file contains two classes using same prop types HOT 4
- Using built-in generics in a generic type fails
- Add support for recursive data types
- aria-{name} and data-{name} props do not work HOT 1
- Issue when using with rollup imports HOT 2
- Support `React.ElementConfig`
- support webpack5
- Suppression only works for the very first directive (which might not be user-controllable)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babel-plugin-flow-react-proptypes.