Giter Club home page Giter Club logo

Comments (3)

BrianPugh avatar BrianPugh commented on May 26, 2024 1

This has been and released in v1.2.0.

from cyclopts.

BrianPugh avatar BrianPugh commented on May 26, 2024

I can add this! Should this have higher or lower priority over directly checking mypackage.__version__? My gut says higher priority. Or would directly checking mypackage.__version__ be redundant (is it already handled by importlib)?

from cyclopts.

Ravencentric avatar Ravencentric commented on May 26, 2024

Yes, importlib should be at the highest priority because it's the "official" way. __version__ seems to be more of a style guide and common practice than an established standard. Regarding whether to check for both or not, unfortunately I'm not well versed on the actual workings of importlib so I don't have anything to say here.

Reference:
https://peps.python.org/pep-0396/#pep-rejection

from cyclopts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.