If connection drops in the middle of worker init, then socket is not connected, but Worker destruct still tries to blindly write to it about net_gearman HOT 3 CLOSED

From what I see, the Connection class does not have isClosed or similar helper function and send($command) also does not check if socket is even connected.
Our logging ignores the @ suppression to catch all hidden errors and warnings and this socket_write issue was revealed due to that

from net_gearman.

I think this will solve the problem. 288afc6

from net_gearman.

Sorry for late reply, that patch will trigger a lot more warnings actually...
public function connect($host, $timeout = 250)
You are now calling function connect without providing the host parameter which will not work at all, so now there are a few more errors...

Checking the codeflow, the connect originally was/is only called in constructor. This means constructor must record the host and timeout parameters in private properties that the connect function can then use and re-use. But that approach still has lots of issues.

Firstly the main issue still remains: if the connection has dropped, then there is no point in the Worker to write "reset_abilities" to a connection that is not open anymore. When you open a new connection, just to tell "reset_abilities" and then close it, it is unneeded open/close operation, because server side already should understand that connection dropped.

If the connection drops then the correct place to handle it is in the Worker because for new connection the abilities must also be resent... So reconnecting in the middle of Connection class without sending abilities list is incorrect...

from net_gearman.