Giter Club home page Giter Club logo

Comments (4)

SerhiiCho avatar SerhiiCho commented on September 28, 2024 1

What about this version?:

image
  1. Added showing which link is active
  2. Changed the user profile link
  3. Reduced the vertical padding on the navbar
  4. Added container inside the navbar to make it look nice on widescreens
  5. Change HTML tag of the navbar from <div></div> to <nav></nav>

I haven't touched the mobile version, currently it looks like this with these changes:

image

from rfc-vote.

brendt avatar brendt commented on September 28, 2024

We can add a PHP logo since this platform is specific for php

I think we need to be careful though: people might think this is an official PHP project, which is not the case.

We can change the font for "rfc votes" logo (later we can make a custom logo)

Makes sense to make a logo at one point (as well as a favicon) — I might ask a designer at JetBrains soon. I don't think we need a cursive font as a temporary placeholder.

We can change the color of the navbar to dark blue to make more PHP related

Isn't purple closer to PHP though? Right now we're using the default Tailwind colors, I'm not against changing it. I choose purple though exactly because of PHP.

The navigation bar itself has to have a nav HTML elements instead of the regular div.

Seems like a good idea 👍

We can add a container inside the navigation bar to fix the issue on the screenshot below that appears on wide screens:

Yes, we should definitely do that 👍

from rfc-vote.

brendt avatar brendt commented on September 28, 2024

Oh I like that! Could you send a PR? :)

from rfc-vote.

SerhiiCho avatar SerhiiCho commented on September 28, 2024

Thanks, I just pushed a PR

from rfc-vote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.