Giter Club home page Giter Club logo

Comments (9)

theofidry avatar theofidry commented on August 19, 2024 1

Many people (including me) like the voting var on the page, it looks nice

Just to clarify: I do love the bar as well, it looks great and its a nice indicator, I just don't find it very intuitive as a "vote action".

from rfc-vote.

SerhiiCho avatar SerhiiCho commented on August 19, 2024 1

Hey @vsergiu93, @MohammadAlhallaq, @Plytas, @joshbonnick, and @brendt. Can someone provide feedback? What are your thoughts on adding 2 buttons for voting? If yes, where should they be placed? If no, how do we make the voting more intuitive? Your opinion is significant guys. Here are a couple of options

image image image

from rfc-vote.

vsergiu93 avatar vsergiu93 commented on August 19, 2024 1

Hey @SerhiiCho, honestly to me all of the options look good, but if I have to pick one I would pick this one:
image
In any case nice work.

from rfc-vote.

SerhiiCho avatar SerhiiCho commented on August 19, 2024
  • When checking another RFCs, currently you see the small box with "Read more" and need to click on the "Read more" link to get there. Maybe the whole thumbnail could be a link instead?

That what we had before, some people prefer link for some reason. I can change it back, I liked it more. We'll see

when click on the "Yes" or "No" button counts, you could be redirect to the submit form

Totally agree on that one!

the form opens but there is no scroll down so if the bar is on the bottom part of the screen, you may not see the form extending.

Also, a great point!

Maybe this whole part could be resolved by having a "vote" button that opens a new dedicated form (in a new page)?

I don't know about this one. Many people (including me) like the voting var on the page, it looks nice. But I get your point, it would have been nice to make it more clear.

Thank you, @theofidry, for these tips, I'll definitely consider your suggestions. You are a huge help 👍🏻 We'll keep this issue open

from rfc-vote.

SerhiiCho avatar SerhiiCho commented on August 19, 2024

I'm thinking to add a feature discovery popover like this to make it more clear about how to vote:

image
image

It basically shows up only once, and after you click "Got it!" button, it will not bother anymore.

from rfc-vote.

theofidry avatar theofidry commented on August 19, 2024

If the intent is to keep the current design definitely. But as stated, I questioned that feature [using the vote bar as an action – the bar itself is cool] because it does not feel intuitive (to the point where a help message is welcomed).

That said it also has the benefit of requiring less efforts.

from rfc-vote.

SerhiiCho avatar SerhiiCho commented on August 19, 2024

Here is another solution, adding 2 buttons like you suggested.

image

I'm not 100% sure about these styles, might think of something else. Maybe placing them above the bar or something.

from rfc-vote.

theofidry avatar theofidry commented on August 19, 2024

Oh looks awesome!

Maybe I would also add a vote button next to in-between "no" and "edit"? In the current screenshot this would feel a bit superfluous but when the RFC is much longer, could help to jump to that section? But then again maybe you don't want people to "skip"... So actually not sure about this

from rfc-vote.

SerhiiCho avatar SerhiiCho commented on August 19, 2024

Having gray buttons does look better IMO, but it's just my cup of tea

image

from rfc-vote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.