Comments (9)
Many people (including me) like the voting var on the page, it looks nice
Just to clarify: I do love the bar as well, it looks great and its a nice indicator, I just don't find it very intuitive as a "vote action".
from rfc-vote.
Hey @vsergiu93, @MohammadAlhallaq, @Plytas, @joshbonnick, and @brendt. Can someone provide feedback? What are your thoughts on adding 2 buttons for voting? If yes, where should they be placed? If no, how do we make the voting more intuitive? Your opinion is significant guys. Here are a couple of options
![image](https://private-user-images.githubusercontent.com/35465417/284296516-e05d176b-5f1c-4693-bdcb-a9bf1e4d9fc8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDgzNDYsIm5iZiI6MTcyNDAwODA0NiwicGF0aCI6Ii8zNTQ2NTQxNy8yODQyOTY1MTYtZTA1ZDE3NmItNWYxYy00NjkzLWJkY2ItYTliZjFlNGQ5ZmM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE5MDcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1N2MxNmU5YWJmYzBkMGM1ODk2YjlhNGViOGMzZTg5YzllYjM3ZWU1MGNjZmFiMjJkMGUzNjA3MTBmNGUyYTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tLnfGnwY48nyUbpSP2ZoTnjY1kG6JPm4KTCc9cL2ekk)
![image](https://private-user-images.githubusercontent.com/35465417/284296389-3d499107-4807-4998-bc78-be6d4051e548.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDgzNDYsIm5iZiI6MTcyNDAwODA0NiwicGF0aCI6Ii8zNTQ2NTQxNy8yODQyOTYzODktM2Q0OTkxMDctNDgwNy00OTk4LWJjNzgtYmU2ZDQwNTFlNTQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE5MDcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5NzA3NDQ1YWNjNTlkZjMzMDdhNTYwZThmZmZhZTM5NWY0N2YzY2YwYmIyMWRlODZhZmJmMGZhZGM2NzQ5NDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3j72wcsIJyGSgSR6RVFQxwqBWq_BBeFGp7NRbXpUZiw)
![image](https://private-user-images.githubusercontent.com/35465417/284298930-5c258cf5-b851-423e-b35d-d4c13ece4257.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDgzNDYsIm5iZiI6MTcyNDAwODA0NiwicGF0aCI6Ii8zNTQ2NTQxNy8yODQyOTg5MzAtNWMyNThjZjUtYjg1MS00MjNlLWIzNWQtZDRjMTNlY2U0MjU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE5MDcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzYjI1YmI1ZGEzNjFkMTlmNWM0M2RkMGU2MTU0OTJiYTgwN2NlNzU0NWFkZGNmZjNkNWMzYjcwMWViNzA4NWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-Pb60ydQBIjWj827BYycVGuht6pjHA5tsAEwDrrGocg)
from rfc-vote.
Hey @SerhiiCho, honestly to me all of the options look good, but if I have to pick one I would pick this one:
In any case nice work.
from rfc-vote.
- When checking another RFCs, currently you see the small box with "Read more" and need to click on the "Read more" link to get there. Maybe the whole thumbnail could be a link instead?
That what we had before, some people prefer link for some reason. I can change it back, I liked it more. We'll see
when click on the "Yes" or "No" button counts, you could be redirect to the submit form
Totally agree on that one!
the form opens but there is no scroll down so if the bar is on the bottom part of the screen, you may not see the form extending.
Also, a great point!
Maybe this whole part could be resolved by having a "vote" button that opens a new dedicated form (in a new page)?
I don't know about this one. Many people (including me) like the voting var on the page, it looks nice. But I get your point, it would have been nice to make it more clear.
Thank you, @theofidry, for these tips, I'll definitely consider your suggestions. You are a huge help 👍🏻 We'll keep this issue open
from rfc-vote.
I'm thinking to add a feature discovery popover like this to make it more clear about how to vote:
It basically shows up only once, and after you click "Got it!" button, it will not bother anymore.
from rfc-vote.
If the intent is to keep the current design definitely. But as stated, I questioned that feature [using the vote bar as an action – the bar itself is cool] because it does not feel intuitive (to the point where a help message is welcomed).
That said it also has the benefit of requiring less efforts.
from rfc-vote.
Here is another solution, adding 2 buttons like you suggested.
I'm not 100% sure about these styles, might think of something else. Maybe placing them above the bar or something.
from rfc-vote.
Oh looks awesome!
Maybe I would also add a vote button next to in-between "no" and "edit"? In the current screenshot this would feel a bit superfluous but when the RFC is much longer, could help to jump to that section? But then again maybe you don't want people to "skip"... So actually not sure about this
from rfc-vote.
Having gray buttons does look better IMO, but it's just my cup of tea
![image](https://private-user-images.githubusercontent.com/35465417/284300829-3689471f-d795-4d87-8400-40ae8b4597af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDgzNDYsIm5iZiI6MTcyNDAwODA0NiwicGF0aCI6Ii8zNTQ2NTQxNy8yODQzMDA4MjktMzY4OTQ3MWYtZDc5NS00ZDg3LTg0MDAtNDBhZThiNDU5N2FmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE5MDcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhMDQyMGQwNmFmYjJmNmFmMGZiYWJlNmNkYWQ4MTA1MGQ5MTNiN2ZlOWJjYTA0MjdmMmYyNjYxNjAxYWZiYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.REEp3CoeuacU-0dUqRr5v0FAFLd9ddPz8yeSaBwTRo4)
from rfc-vote.
Related Issues (20)
- Clickable cards on the homepage HOT 6
- Linkedin share issue HOT 2
- Argument social share buttons should link to argument directly
- Pagination Breaks After Edit HOT 1
- Code block styling: small size HOT 3
- The color of strong tags in dark mode is difficult to read HOT 1
- Vote bar is not aligned in card
- RFC suggestion/discussion HOT 4
- 🐛 Error when trying to submit an argument HOT 9
- ❓ Not used Blade files? HOT 2
- Error 500 when trying to change account e-mail HOT 1
- Move tutorial from RFC page to About page
- Code highlighting is broken for code samples
- Clean the codebase by removing unused files
- Code blocks lack contrast in bright mode HOT 4
- unreadable code snippet when using ligth mode HOT 2
- RFC suggestions issue
- Change styles of monospaced inline code examples in RFC description
- Performance issues HOT 23
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rfc-vote.