Giter Club home page Giter Club logo

Comments (2)

brendan-duncan avatar brendan-duncan commented on August 21, 2024

I'll see if I can do anything to improve that performance. Certainly PC extractors will have significant advantage there, they can get away with a lot of things Dart can't, but it can certainly be improved. The size of the EOCD isn't the issue, it's that they put it at the end of the file, meaning you have to search backwards, and there's nothing to say there can't be any amount of other data after the EoCD, meaning you can't just read the last 64kb. So the theoretical worse case is it has to read the entire file backwards, which is what's happening.

from archive.

Marc-R2 avatar Marc-R2 commented on August 21, 2024

Hi there. I'm also facing a similar issue. Even when reading small corrupted files (5 MB) from a network storage, it takes minutes in this mode. Initially, I thought the isolate had frozen, but then when I looked into the code, I found this loop.
I'd love to hear if there've been any updates regarding this issue.

Update - Found a bug with duplicate checks in _findSignature #351. This improves reading time. Please have a look.

from archive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.