Comments (9)
Woah, good find! I have importHelpers
set to true
in tsconfig.json
but I still had tslib
in the devDependencies
.
The weird thing is that I can't reproduce this issue. I tried npx create-next-app@latest
and was able to run useCountdown
with no issues. What are you using to build your site? Do you have a reproduction or GitHub repository I could look at?
from use-countdown.
Can we re-open this?
The reason this error occurs with vite is formulated here.
Reproduce:
npm create vite@latest tslib-bug -- --template react-swc-ts
cd tslib-bug
npm install
npm add @bradgarropy/use-countdown
# edit src/App.tsx to import and use use-countdown
npm dev
Result:
➜ press h to show help
✘ [ERROR] Could not resolve "tslib"
node_modules/@bradgarropy/use-countdown/dist/index.js:3:22:
3 │ var tslib_1 = require("tslib");
╵ ~~~~~~~
from use-countdown.
Thank you for the reproduction @msopacua! I was able to successfully reproduce, as well as compare the output bundle sizes with and without tslib
. As expected, the bundle is smaller with tslib
.
Without tslib
package size: 7.4 kB
unpacked size: 25.5 kB
With tslib
package size: 7.2 kB
unpacked size: 24.7 kB
from use-countdown.
@all-contributors please add @narthur for bug
from use-countdown.
I've put up a pull request to add @narthur! 🎉
from use-countdown.
@all-contributors please add @msopacua for bug
from use-countdown.
I've put up a pull request to add @msopacua! 🎉
from use-countdown.
@all-contributors please add @msopacua for code
from use-countdown.
I've put up a pull request to add @msopacua! 🎉
from use-countdown.
Related Issues (9)
- add Steven Creates as a contributor HOT 2
- Implementing a way to freeze/stop the timer HOT 11
- Implementing a reset countdown feature HOT 8
- Add a feature that will count the days in between the 2 dates HOT 2
- Add a new feature: allow changing the duration of the countdown HOT 6
- calling reset() with a time value is causing an error in Next.js (v12) HOT 5
- Is there a way to start with the countdown paused? HOT 9
- Countdown overtime HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from use-countdown.