Potential mixin contributions - sortable-listview & spreadsheet-response about django-braces HOT 14 CLOSED

I like the idea of the django-spreadsheetresponsemixin without the requirement of the excel library. CSVResponseMixin maybe?

@kennethlove and I looked over the code and one thing I noticed that might be nice to set is the filename of the csv returned. It would be nice to dynamically set that.

How long has the django-spreadsheetresponsemixin code been running in production?

from django-braces.

On both of these, django-braces is released under an MIT license and I'd rather not have to deal with dual licensing, so your submissions would need to be MIT licensed.

django-sortable-listview looks really promising. A couple of things I've seen:

• https://github.com/aptivate/django-sortable-listview/blob/master/sortable_listview/views.py#L51 - you might want to specify a maxsplits limit on the split() to ensure that you only get two items in the list.
• I also wonder if this shouldn't extend MultipleObjectMixin instead of ListView but I can't think of a good example of where someone might use this that isn't ultimately a ListView. So....whatever, I'm just being paranoid.

from django-braces.

Thanks for the speedy response.

"I like the idea of the django-spreadsheetresponsemixin without the requirement of the excel library. CSVResponseMixin maybe?" - sounds great

"might be nice to set is the filename of the csv returned. It would be nice to dynamically set that." +1 (already on our todo list - (birdsarah/django-spreadsheetresponsemixin#4)

"How long has the django-spreadsheetresponsemixin code been running in production?"- barely begun - its gone up on a client project last week, which has teased out some issues (UTF-8, headers etc), but certainly in infant stage (partly why it seemed like a good time to ping you) so am happy to wait for as long as you think appropriate. Will work on splitting out the CSVResponse piece though so its easier to reuse when ready.

Quick question: You use pytest and I spotted a couple of tests that use py.test assertion style, but many use unittest style, is there a convention you prefer.

from django-braces.

re: assertions. The tests end up being written by contributors as things come in, so we don't really have a defined format yet (we're working on a CONTRIBUTION doc). Since the tests themselves are written in and run by py.test, the py.test assertion style is probably more appropriate.

from django-braces.

Also, just for sanity's sake, when you submit these, please submit them as separate PRs.

from django-braces.

"MIT License" - no problem.

Thanks for the tips on sortable-listview, will add to the TODO list, haven't thought through MultipleObjectMixin.

On django-sortable-listview, it currently has some default template and css, the css can totally go, the templates are kind of useful, but maybe they can just go into the documentation. Do you have a preference?

"Also, just for sanity's sake, when you submit these, please submit them as separate PRs." of course :D just striking up a conversation

from django-braces.

We haven't provided any templates for users up to this point (since everything is a behind-the-scenes mixin) so I'm not sure about providing them. Definitely don't need to provide the CSS, since lots of people won't want to use Bootstrap. I think, so long as the templates aren't expected by the mixin, it would be OK to include them.

from django-braces.

^^ 👍

from django-braces.

sounds like a plan - thanks!

from django-braces.

FWIW, django-sortablelistview is in production (http://www.inasp.info) - been up for a month with no apparent issues

from django-braces.

Sarah, how about creating an -extra package for templates and CSS?

from django-braces.

@samastur if it's only a couple of templates and no static files, I don't see the point in creating a maintaining a completely separate package.

from django-braces.

Old issue. If anyone is interested in making this happen a PR would be awesome.

from django-braces.

Ugh - can't believe this is coming up on two years :s Thanks for closing it. Will certainly open a new PR when my backlog and ambition are a little more in sync!

from django-braces.