Formating error when generating esil about bin2ml HOT 9 CLOSED

It's not spam! All of these are valid. I'll look to fix the new one too!

from bin2ml.

Hey for the most part your changes worked well. I did find another little one nothing major. Otherwise thank you for the fixes...

bin2ml extract --mode cfg --fpath ../binary --output-dir thisfilefolderdoesnotexists

Unable to create file!: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)```

from bin2ml.

Sorry I feel like I'm spamming now :-( --- I tried using dedup this morning and even with valid expected data I was getting an error msg.

# using esil file
root@ae6a62491516:/app# touch out.json
███████████████████████████████████████████ 1/1
root@ae6a62491516:/app# bin2ml dedup esil --filename file_cfg-efs.json --output-path out.json 
thread 'main' panicked at src/dedup.rs:282:45:
Failed to create writer: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

# wrong type of json file
root@ae6a62491516:/app# bin2ml dedup esil --filename file_cfg.json --output-path out.json 
███████████████████████████████████████████ 1/1
thread 'main' panicked at src/dedup.rs:75:14:
Unable to load function data from file_cfg.json: Error("invalid type: sequence, expected a map", line: 1, column: 0)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)
root@ae6a62491516:/app# ls
file_cfg-efs.json  file_cfg.json  out.json

# using original binary file gives me no errors
root@ae6a62491516:/app# bin2ml dedup esil --filename file --output-path .

However even with no errors nothing is outputted.

from bin2ml.

Thank you again for the great feedback @cielonet. I will add some checks to the CLI 👍🏼

from bin2ml.

@cielonet , I have addd some initial validation to the CLI in main. If you have a mo, could you give it a try?

from bin2ml.

Hey for the most part your changes worked well. I did find another little one nothing major. Otherwise thank you for the fixes...

bin2ml extract --mode cfg --fpath ../binary --output-dir thisfilefolderdoesnotexists

Unable to create file!: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)```

I think this behaviour is correct. I didn't want to create repos that could be typos etc automatically and instead assume the directory is created beforehand. Does that make sense for your use case?

from bin2ml.

Hey for the most part your changes worked well. I did find another little one nothing major. Otherwise thank you for the fixes...
bin2ml extract --mode cfg --fpath ../binary --output-dir thisfilefolderdoesnotexists

Unable to create file!: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)```

I think this behaviour is correct. I didn't want to create repos that could be typos etc automatically and instead assume the directory is created beforehand. Does that make sense for your use case?

I am no expert in rust. Far from it, but I believe there is a way to catch these types of errors more elegantly so that core dumped isn't outputed using match.

match file_result {
        Ok(_) => {
            println!("File created successfully!");
            Ok(())
        }
        Err(err) => {
            if err.kind() == io::ErrorKind::NotFound {
                Err(io::Error::new(
                    io::ErrorKind::NotFound,
                    "The specified directory does not exist.",
                ))
            } else {
                Err(err)

This is just the QA guy in me :-). Thank you for looking over it.

from bin2ml.

@cielonet, I think I've fixed all of these on main. Could you check them out?

from bin2ml.

Assuming everything is all good! 👍🏼

from bin2ml.