Comments (4)
was just reading the source, and yes it might just be adding initContainers in the filter in this method
Line 35 in dab2d1e
I don't have time until next week, but if i get it working i'll do a PR for it.
Thanks for the pointers as well.
from kail.
Great idea. If Read Log works for init-containers then yeah, it should be doable.
I don't have time at the moment to get to it, but will try to get to it at some point.
If anyone else wants to tackle the issue, it will probably take something like
- include init containers by looking at
InitContainerStatuses
here - figure out reasonable behavior for when to display init container logs and when to stop monitoring them.
from kail.
So, #15 seems to work in my local testing .. regarding when to stop monitoring them, if i understand the code correctly, then cleanup should already happen, as finished init containers will not be considered from the filter (they're not running anymore), and thus will be automatically prune from the sources.
if pms, ok := c.monitors[id]; ok {
for source, pm := range pms {
if !sources[source] {
pm.Shutdown()
}
}
}
Is that understood correctly?
From the debug logs in my testing example it looks like it at least where i get
DEBU[0025] removing source prod/api-7805699-0mpq0@init cmp=kail.controller
from kail.
@davidreuss: yep, that's right.
from kail.
Related Issues (20)
- Feature request: --follow=false HOT 2
- Advantages over stern? HOT 1
- Support regular expression or auto completion?
- Release? DNS on macOS with VPNs doesn't work HOT 1
- not able to get logs of two pods
- Running Kail without cluster role
- Feature: ARM64 builds HOT 11
- Add support proxy-url from config
- Homebrew: Calling `bottle :unneeded` is deprecated HOT 3
- Become a Krew extension HOT 3
- arm64 support in krew HOT 6
- Allow not printing prefix HOT 1
- Release of sts support HOT 1
- Plans for a Windows binary? HOT 8
- RBAC HOT 1
- missing example of ignore HOT 1
- Access issue in release github action, failing to update homebrew-repo kail.rb
- brew error: SHA256 mismatch HOT 4
- Update link for `minikube` HOT 1
- Feature request: automatically reconnect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kail.