Unable to launch this plugin in Kicad 5.99 about kicad-jlcpcb-tools HOT 6 CLOSED

Seems that commenting out self.logger.debug("Download success") in library.py makes it at least not crashing. Maybe because that self.logger.debug shouldn't be called in worker thread?

from kicad-jlcpcb-tools.

Also, if I comment out handler2 in mainwindow.py (without commenting self.logger.debug("Download success")), the problem will not happen neither. So it's obvious that we can't operate the log textbox directly in the log handler (which will have the textbox operated in the downloader thread, causing the crash). Instead, we should probably send a event to the main thread in the log handler. As I am not familiar with wxPython, could anyone please help to solve this problem?

from kicad-jlcpcb-tools.

You mean an wx event that the main task then sends to the logger?

from kicad-jlcpcb-tools.

You mean an wx event that the main task then sends to the logger?

I don't quite understand what you refer to. From my basic understanding, every UI operation should be done in UI thread. The logger handler2, which will operate the logbox, may be called from the downloader thread, thus violates this rule. I think we should not operate logbox directly in handler2. Rather, we should post a event to the UI thread in the log handler, and add log to the logbox within the UI thread.

from kicad-jlcpcb-tools.

Sounds right, I'll have a look into this next week!

from kicad-jlcpcb-tools.

This should be solved in 2021.12.1

from kicad-jlcpcb-tools.