Giter Club home page Giter Club logo

Comments (12)

Bouni avatar Bouni commented on June 22, 2024 1

You mean just query for already selected parts?
That might be an option.
Or even better, when the user clicks the select part button on the library dialog, the additional info is fetched from the API and stored in the part_assignments.csv as well. That way we only query when needed and do not re-query for already selected parts.

And maybe add a query details button for the library that triggers the query and spawns a new modal with picture and detailed infos!?

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024 1

Ok, then lets go for that approach!

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024 1

I've implemented a first version 5690b32, the result is not yet persisted but the modal works already:

image

Is that about what you wanted it to look like?

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024 1

OK, found the problem, added a button to the main window as well that lets you show the part details for already selected parts.
I concider this issue solved 😄

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024

I fixed your first point: "incorrect description" with 0ce0c3d
The encoding of the CSV is gbk rather than iso-8859-1

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024

I'm not sure how to iclude the better data from LCSC in a proper way 🤔
Maybe we add an info button to each row that fetchs the data from LCSC API by the LCSC number.
I did a quick example here: https://gist.github.com/Bouni/3d79ddbd68b8fccceb196ad5c9598f1f
It returns a huge amount of data for a single part, so we might show that as another modal!?

from kicad-jlcpcb-tools.

bvernoux avatar bvernoux commented on June 22, 2024

After check of https://gist.github.com/Bouni/3d79ddbd68b8fccceb196ad5c9598f1f
I think it will be perfect to concatenate (with space between param and at end "," when there is an other item after)

  • brandNameEn {space} productModel {space} catalogName {space} encapStandard {,}
  • Then concatenate each "paramVOList" => "paramNameEn" {space} "paramValueEn" {,}
  • For that example you could display it like that:
    • UNI-ROYAL(Uniroyal Elec) 1206W4F1001T5 Chip Resistor - Surface Mount 1206, Power(Watts) 0.25W, Tolerance ±1%, Temperature Coefficient ±100ppm/℃, Resistance 1kΩ

Note: it seems 'productIntroEn' field could be interesting too it returns for that example

  • '0.25W ±1% ±100ppm/℃ 1kΩ 1206 Chip Resistor - Surface Mount ' 'ROHS',
  • It will contains all "paramVOList" but I'm not sure it is accurate and for some parts those details are maybe not present ... (when they shall be part of paramVOList to be checked)

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024

The question is when do we query the API?
If you search for let say "10k", the search yields 625 resuts from the CSV, which means we have to do 625 API calls.
This is far from ideal and LCSC might block the API for such a behaviour.

from kicad-jlcpcb-tools.

bvernoux avatar bvernoux commented on June 22, 2024

The best will be probably to query those API for each part in our BOM with a special "refresh button" (which could be called "LCSC part details") for example with a new column and store that in the part_assignments.csv
What do you think about that ?

from kicad-jlcpcb-tools.

bvernoux avatar bvernoux commented on June 22, 2024
  1. The best is your proposal:

when the user clicks the select part button on the library dialog, the additional info is fetched from the API and stored in the part_assignments.csv as well. That way we only query when needed and do not re-query for already selected parts.

  1. It will be amazing to have

a query details button for the library that triggers the query and spawns a new modal with picture and detailed infos!?

  • Like that we will have all in one to choose correctly the good parts and we will do not need anymore to use a web browser to check the different parts details ...

from kicad-jlcpcb-tools.

bvernoux avatar bvernoux commented on June 22, 2024

Amazing !! it work fine on Windows10 tested with latest KiCad Nightly (kicad-r24113 from today)

  • Could you add also the "Show part details" button in main Window (JLCPCB Tools) on a selection which have a LCSC part of course ?
    • It will be amazing to do a review of parts with all possible details on part (maybe it will be not required when we will have additional details from LCSC but it is nice to check the part like that with the photo and additional details ...)

from kicad-jlcpcb-tools.

Bouni avatar Bouni commented on June 22, 2024

Yes, sure. Just for your information, there's a bug in the info gathering for some of the parts which I need to fix in order to get it working for all the parts.

from kicad-jlcpcb-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.