Giter Club home page Giter Club logo

Comments (10)

handlerug avatar handlerug commented on June 19, 2024 1

Thanks for the report! I think I'm the one who introduced the second bug; I'll fix it today later.

from mycorrhiza.

bouncepaw avatar bouncepaw commented on June 19, 2024 1

Uh let's close this issue then

from mycorrhiza.

bouncepaw avatar bouncepaw commented on June 19, 2024

I updated the engine to the specified commit on https://mycorrhiza.wiki and here's what I can say.

  1. Search is case-insensitive, compare results of https://mycorrhiza.wiki/title-search/?q=Essay and https://mycorrhiza.wiki/title-search/?q=essay
  2. It does not, see https://mycorrhiza.wiki/title-search/?q=owl

The only bug I found is that the search bar does not work (it would send you to https://mycorrhiza.wiki/title-search?q=kek instead of https://mycorrhiza.wiki/title-search/?q=kek (and both should work, actually)). I guess @handlerug will fix that.

from mycorrhiza.

kseistrup avatar kseistrup commented on June 19, 2024

I don't know what to say. My wiki has exactly 3 pages: DNS, Syphon, and kas. If I use the title-search field to search for “Syphon” I am shown the page. If I use the title-search field to search for “syphon” I am sent to a 404 page. The former will send me to /title-search/?q=Syphon, the latter will send me to /title-search?q=syphon. Perhaps I'm just hit by the bug you're mentioning, but I don't understand why one will send me somewhere and the other elsewhere.

Perhaps we best wait the for bugfix…

from mycorrhiza.

handlerug avatar handlerug commented on June 19, 2024

Should be fixed in eb22cf2

from mycorrhiza.

bouncepaw avatar bouncepaw commented on June 19, 2024

Works fine for me.

One more thing. Should we show something like your search returned nothing or keep it the current way?

from mycorrhiza.

handlerug avatar handlerug commented on June 19, 2024

It probably should (that whole title search thing is a big hack anyway...)

from mycorrhiza.

kseistrup avatar kseistrup commented on June 19, 2024

Could it be because I am running Mycorrhiza behind a reverse proxy that I am seeing different things?

Let me try @handlerug's fix…

from mycorrhiza.

bouncepaw avatar bouncepaw commented on June 19, 2024

I run all my wikis through reverse proxies (nginx, in particular) and don't have an issue

from mycorrhiza.

kseistrup avatar kseistrup commented on June 19, 2024

Well, that's weird because it's very reproducible here (I am using Caddy as webserver and Firefox as browser).

But I am happy to be able to report that @handlerug's fix is giving me what I want: case-insensitive search and no 404 page.

That Mycorrhiza says that “Hyphae that have matched the query are listed below” and the list is empty is a very minor issue for me.

Thanks.

from mycorrhiza.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.