Comments (14)
Danila came up with a simple solution in the end: linking all the primitive diff pages. See #215 for the merged solution.
from mycorrhiza.
What is a full diff page? Please describe what is there
from mycorrhiza.
@bouncepaw ordinary primary diff but for full commit instead for one hypha
from mycorrhiza.
How does it work for changes to non-text files? Does it link anything else?
from mycorrhiza.
@bouncepaw doesn't matter yet. I think we should just create link to current primary diff and fix diff for work without hypha first.
from mycorrhiza.
What you mean ‘doesn't matter yet’? Do you want to simply ignore non-text files? That sounds ok.
I don't understand the second sentence. Also, it is primitive diff, not primary diff.
from mycorrhiza.
I don't want us to touch diff itself yet. I just want us to create link to it and fix 502. After fix, we might think about diff update, but not now. And yes, I mean "primitive diff", "primary diff" is typo.
from mycorrhiza.
What do you mean fix 502?, it's not an error.
You want this:
- On
/recent-changes/
, you want the hashes link to/primitive-diff/<hash>
. /primitive-diff/<hash>
is different from/primitive-diff/<hash>/<hypha>
./primitive-diff/<hash>
is a concatenation of all valid/primitive-diff/<hash>/<hypha>
.- The whole diffing stuff should be reworked later.
Did I get you right? Seems good to me.
from mycorrhiza.
it reset connection or return 502 Bad Gateway if you use nginx.
For example:
https://mycorrhiza.wiki/primitive-diff/HEAD..HEAD~40/mycomarkup is diff for mycomarkup hypha.
https://mycorrhiza.wiki/primitive-diff/HEAD..HEAD~40/mycorrhiza_wiki is diff for mycorrhiza_wiki hypha
https://mycorrhiza.wiki/primitive-diff/HEAD..HEAD~40 is looking like full diff but it doesn't work and return 502 for every diff.
from mycorrhiza.
@bouncepaw /primitive-diff/<hash>
should be the same as /primitive-diff/<hash>/<hypha>
but for full commit.
from mycorrhiza.
The fact that first two links show something is a bug, actually. Only hashes are meant to go there. The third shows nothing, yeah, that's how it's made.
/primitive-diff/ should be the same as /primitive-diff// but for full commit.
This is conceptually impossible and makes no sense, commits can change multiple hyphae, and they often do.
from mycorrhiza.
The fact that first two links show something is a bug, actually.
Errr… isn't it feature? Okay… (but I don't think you should fix it)
conceptually impossible
You didn't understand me. I mean /primitive-diff/<hash>
should show change for current commit but for all hyphae that commit has.
from mycorrhiza.
Errr… isn't it feature?
It's not. I'm thrilled by your creativity though. I'll leave it be for now, but won't hesitate to accept a fix from someone else.
You didn't understand me. I mean /primitive-diff/ should show change for current commit but for all hyphae that commit has.
So it's not ‘/primitive-diff/ should be the same as /primitive-diff// but for full commit’, but rather ‘/primitive-diff/ is a concatenation of all valid /primitive-diff//’; I understood you correctly the first time.
Anyway, got you. The feature is a good one. One day we'll have it.
from mycorrhiza.
Okay, thanks 👍
from mycorrhiza.
Related Issues (20)
- `silentGitsh` ignores environment variables HOT 1
- Changing passwords HOT 10
- Make a new category auto-complete based on JavaScript
- Category descriptions
- Mycorrhiza 1.15 HOT 2
- Categories is not available HOT 8
- Make -create-admin more known HOT 1
- Rename hypha renames git repo instead HOT 5
- custom.css file HOT 6
- Caching static resources HOT 2
- Replace default static files HOT 5
- naming hypha 'wiki' results in unexpected behavior HOT 1
- A proper admin creation
- Language should be picked in settings by admins, not on client
- External links with a globe icon should always be on the same line HOT 7
- Add local time buttons in the editor
- Interwiki transclusion
- Can't remove media file from hypha HOT 4
- Math/LaTeX support in markup HOT 2
- Decrease tab-size HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mycorrhiza.