wrong defaults on MakoTemplate about bottle HOT 5 CLOSED

In fact, the default_filter should be set as None to reflect the original default value.

The goal of this patch was to provide exectly the same as without it.

The default filter become unicode only if disable_unicode is False.

see Template's --init-- of mako/template.py (double underscore gives bold :/ )

Regards,
Damien

from bottle.

Fixed here, I think Defnull will apply it in main stream soon.

MakoTemplate charset is intended to be used like this:
from bottle import [....], MakoTemplate

MakoTemplate.output_encoding = 'utf-8'
MakoTemplate.input_encoding = 'utf-8'
MakoTemplate.default_filters = ['decode.utf8'] # ot whatever you whant :)

Regards,
Damien

from bottle.

Fixed. Thanks for your help.

Damien: Unfortunately I can't easily pull from your fork because you have a bunch of commits I don't need (all the merge conflict resolving commits for example). For small patches it is no problem to cherry-pick them one by one, but if you plan to contribute a huge patch with lots of commits, please create a clean branch first so I can just pull that branch :) That saves your commit history too, which would otherwise be destroyed by git-cherry-pick.

from bottle.

In my opinion the default for output_encoding and input_encoding should be 'utf-8',

I agree completely, this is the only sensible default, and it is really annoying to have to set it.

from bottle.

Not exactly, the default should be ISO-8859-1 as in the HTTP/1.1 definition.
So to be perfectly compliant with implementation with Mako, I setted it to None, but maybe it should be iso.

I agree about the annoyment because I also code templates as UTF-8.

Regards,
Damien

from bottle.