Giter Club home page Giter Club logo

Comments (16)

faergeek avatar faergeek commented on June 28, 2024 1

Is it possible to implement "radio logic" instead of "checkbox logic" for extension activation?
So instead of "enable/disable this tab" it should "switch control to that tab".

from keysocket.

DragoCubed avatar DragoCubed commented on June 28, 2024 1

any update on this? I really hate it when I press play and it starts playing everything.

from keysocket.

borismus avatar borismus commented on June 28, 2024

This goes quickly into a fair complex area: media controls in general. I wrote a long blog post about it about a year ago: http://smus.com/remote-controls-web-media/

I'm open to simple, cleanly implemented ideas that will approach the active tab stack implementation. I think this extension is a good candidate to prove the concept.

from keysocket.

feedbee avatar feedbee commented on June 28, 2024

Extension should show Page Action icon on the pages it supported to control. First of all it's good to see for the user which tabs are currenly controlled. So, using Page Action user can get possibility to disable tabs he doesn't want to controll manually. Isn't it simple and clean idea?

from keysocket.

borismus avatar borismus commented on June 28, 2024

I don't think that the page action idea is a good one. The real solution
needs to be a lot more elegant, something like this:
http://smus.com/remote-controls-web-media/

On Tue, Feb 24, 2015 at 11:12 PM, Valera Leontyev [email protected]
wrote:

Extension should show Page Action icon on the pages it supported to
control. First of all it's good to see for the user which tabs are currenly
controlled. So, using Page Action user can get possibility to disable tabs
he doesn't want to controll manually. Isn't it simple and clean idea?


Reply to this email directly or view it on GitHub
#82 (comment).

from keysocket.

feedbee avatar feedbee commented on June 28, 2024

If I listen music with (for example) yandex.music.ru in the background tab and surfing social network with media support vk.com (for example), topmost tab will be vk.com, while I want to control yandex.music.ru. While your idea with media stack is very interesting, I think user need to have possibility to choose tab he wants to control manually. And it's a good practice to show user which tab is currently under control. Page action is the way to resolve it both.

from keysocket.

borismus avatar borismus commented on June 28, 2024

The other drawback of page action is that the user won't know which tab is
controlled until they navigate to it. I really don't think this is a good
solution.

On Wed, Feb 25, 2015 at 10:29 PM, Valera Leontyev [email protected]
wrote:

If I listen music with (for example) yandex.music.ru in the background
tab and surfing social network with media support vk.com (for example),
topmost tab will be vk.com, while I want to control yandex.music.ru.
While your idea with media stack is very interesting, I think user need to
have possibility to choose tab he wants to control manually. And it's a
good practice to show user which tab is currently under control. Page
action is the way to resolve it both.


Reply to this email directly or view it on GitHub
#82 (comment).

from keysocket.

feedbee avatar feedbee commented on June 28, 2024

Yes, user won't know which tab is controlled until he navigates to it. But it's the only way to get the knowledge. Currently there is no any way to know what tabs are controlled. If media keys don't work, user can't even figure out, is it related to key binding issue, or just current tab is not recognized to be supported by extension.

I personally was in this situation (Pull Request # 94) and had lost about an hour researching chrome keys binding features until I looked into the code and found roots of my problem.

However, I agree with you that it's not the best solution to resolve current discussing issue – 'Several opened tabs with music'. Does it make sense to create another issue addressing user's (my) desire to know what tabs are controlled? I'll try to contribute if you accept this solution. Thank you for response.

from keysocket.

borismus avatar borismus commented on June 28, 2024

Valera, this sounds good. So the plan would be to show a page action on
tabs that are media controllable. There would be two states which would
need to be visually reflected in the page action:

  1. capable of receiving media events, and
  2. actively focused (only one tab can be actively focused)

This would also require you to implement a notion of page focus in the
extension, so that only one of the tabs gets the events. There would also
need to be a stack of tabs to handle the case that the focused tab closes.
Maybe clicking the page action on a non-focused tab would manually make it
focused.

If you were to do this, that would solve the problem in a pretty good way,
I think!

On Thu, Feb 26, 2015 at 12:36 AM, Valera Leontyev [email protected]
wrote:

Yes, user won't know which tab is controlled until he navigates to it. But
it's the only way to get the knowledge. Currently there is no any way to
know what tabs are controlled. If media keys don't work, user can't even
figure out, is it related to key binding issue, or just current tab is not
recognized to be supported by extension.

I personally was in this situation (Pull Request # 94
#94) and had lost about an
hour researching chrome keys binding features until I looked into the code
and found roots of my problem.

However, I agree with you that it's not the best solution to resolve
current discussing issue – 'Several opened tabs with music'. Does it make
sense to create another issue addressing user's (my) desire to know what
tabs are controlled? I'll try to contribute if you accept this solution.
Thank you for response.


Reply to this email directly or view it on GitHub
#82 (comment).

from keysocket.

feedbee avatar feedbee commented on June 28, 2024

It's rather complex task to implement all this at once. Page focus is complex task be itself. So, I implemented simpler part of the scope – page action with enable/disable click handler. Next part is related to page focus subject. I can't promise that I will get the work done, but I'll try. I'll appreciate if you merge my PR and update the extension in the store. May be some text style fixes are desired for my commits, because I'm not very good English writer.

from keysocket.

MrKossmo avatar MrKossmo commented on June 28, 2024

I've just installed this extension. And it works fine. Except one thing.

I thought about the same thing like topicstarter. This extension should be "off by default". That makes me confused a little. I use multi tab surfing on media sites usually (vk, twitch, youtube). For example, I start music to play, check some another tabs, and go to play game. Tabs priority has changed. While in game, i pressed play/pause once. And few tabs switced its status (twich stream, radiopodcast paused, music from few tabs started or not). It makes me to alt+tab my game (what i don't want to do) to fix problems. Something wierd...

It should be "off by default" is first that i was thinking about. To make it more natural, i want to have possibility to control music, not to have control whole time. I want to control music from "this one" tab, and only. I switch it to control. Launch game. And pressing play/pause/next doesn't ruin few other tabs.

Make it "off by default"

Thanks!

from keysocket.

feedbee avatar feedbee commented on June 28, 2024

This task will be done sometime either by me, when I'll have enough time to do it, or by someone else if anyone would like to write the code.

from keysocket.

ignat980 avatar ignat980 commented on June 28, 2024

Looks like PR #259 solves this issue, looks like a good idea. It also removes the context menu options because of the different flow, but honestly I never even use them.

from keysocket.

feedbee avatar feedbee commented on June 28, 2024

It solves a part of the issue. Please, read my comment there. If we would able to create new woking logic that covers the whole issue, it would be great.

from keysocket.

ChildishGiant avatar ChildishGiant commented on June 28, 2024

Another solution could be an option to only control a tab if it is the focused tab. I mainly use this extension to play and pause videos on my second monitor when in games, so this would solve my problem.

from keysocket.

DragoCubed avatar DragoCubed commented on June 28, 2024

I would prefer it if it:

  • paused all currently playing media
  • played any media on the current tab
  • played any media that was last played if there isn't any currently playing

I actually uninstalled this extension now that Chrome supports media keys and went to chrome://flags to disable single audio source enforcement (just to tell Google that I don't want enforcement as it should be a user facing option).

from keysocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.