Comments (5)
To explain this issue:
The JSFiddle linked above includes the line:
<tbody data-link="{for people tmpl='#people .item-template'}"></tbody>
It loads the template under the script element with class "item-template"
, which is itself a descendant of the element (in fact a <div>
) which has ID "people"
.
The selector '#people .item-template'
- a "descendant selector" starts with a '#'
, and the previous JsRender code assumed that a selector starting with a '#'
is an "ID selector". However the presence of white space in the selector means that it is not a valid "ID selector" and is in fact a "descendant selector". The bug fix ensures that JsRender no longer assumes that a selector starting with "#"
is an "ID selector", and instead interprets the selector correctly, and so loads the correct template in the JSFiddle example.
The issue is with JsRender as well as with JsViews (which uses JsRender)
from jsviews.
Thanks for calling this out, Lee. I have a fix, which I will share with you in the coming days...
from jsviews.
You can test my proposed fix, using this updated version of jsviews.js:
It has line 1125:
} if (!elem && $.fn && !$sub.rTmpl.test(value)) {
which replaces the previous version:
} else if ($.fn && !$sub.rTmpl.test(value)) {
Let me know if this works for you.
Thanks
from jsviews.
Thanks yeah that seems to do the trick.
from jsviews.
Resolved in release v1.0.13
from jsviews.
Related Issues (20)
- linked tag property changed handler called when it shouldn't HOT 51
- {{for ..}} emits <tr> and <td> tags HOT 1
- for tag with range and data-linked tr give error when removing object from array HOT 5
- Delimiters not working for "[ " and " ]" HOT 2
- linking of selected value on select element does not work correctly with all jquery versions HOT 5
- jsrender.min.js.map truncated HOT 6
- Observable change error, when loading jquery.observable.js before jsrender.js, and using contextual parameters and sorted {{for}} HOT 6
- removeView performance HOT 2
- $.observe/$.unobserve performance degradation over time HOT 5
- If the selected value of a data-linked <select> is set prior to adding options, selection is not always established correctly HOT 3
- multiselect not updating when linked array changes HOT 10
- Binding to computed functions: onBind callback called twice. If computed function has no setter , "... is not a function" exception thrown HOT 6
- html comments not working in tables HOT 4
- performance improvement in JsObservable HOT 2
- Formatting a number in data-link ? HOT 2
- Top-level data-link="{for...}" does not work on a 'select' element HOT 3
- LinkTo not refreshing DOM on empty value HOT 5
- Checkboxgroup enhancement and oldValue issue HOT 26
- Observe array of objects path HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsviews.