Comments (4)
@dellaert Brilliant! Next week, hopefully will come back to this important one.
Cheers.
from gtsam.
Work in progress here.
On this:
One things is that we definitely want to be backwards compatible on update, including in wrappers.
Let me know if this solution (100% backwards compatible) seems better.
Next, we can add to that structure the new parameters needed to solve this bug.
On this:
βIn theory, even smart-factors know which keys they are connected to, so I am not sure why simply giving the keys is not an option.β
It would be great to do it like that; last time I spent some time with this, though, it looked like it was not possible, but will give it another try just in case I missed something.
from gtsam.
I'm super happy this is solved, yay!
@dellaert Please, take a look at the proposed solution in the PR #25.
βIn theory, even smart-factors know which keys they are connected to, so I am not sure why simply giving the keys is not an option.β
Perhaps there's another way, but I though that for iSAM2::getAffectedFactors() to work properly:
gtsam/gtsam/nonlinear/ISAM2.cpp
Lines 109 to 113 in dc774ed
we need variableIndex_
to be up-to-date, and that implies requesting from the user this information, that's the reason of the new parameter to update()
.
from gtsam.
Excellent, I will review...
from gtsam.
Related Issues (20)
- Trouble using a Custom Factor HOT 1
- PreintegrationParams parameter not exposed in Python wrapper HOT 2
- Custom factor without Jacobian HOT 2
- Support bazel in addition to cmake HOT 1
- GNC Example HOT 1
- ISAM2 recalculatelaBatch() BUG .When using Inc smoother, CPU usage increases HOT 2
- Resizing factor graph when using iSAM HOT 1
- /usr/local/include/gtsam/base/OptionalJacobian.h:126:43: error: function definition does not declare parameters HOT 1
- Avoid dense fill-in during margianlization HOT 1
- Possible quaternion conversion bug HOT 3
- # include<gtsam/navigation/ImuFactor.h> cannot comiled successfully HOT 1
- RuntimeError: Shonan::run did not converge for given pMax HOT 9
- BoundingConstraint1 with double parameter HOT 2
- Fisheye calibration factor in Python HOT 1
- Is the current latest tag a pre-release? HOT 4
- Matlab "IMUKittiExampleGPS" example result in an error HOT 3
- Generating Matlab toolbox on windows fails
- Error in test scrpipt "TranslationAveragingExample.py" HOT 4
- gtsam doesn't build on i386 or armhf HOT 29
- KeySet class in python is missing methods HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtsam.