Giter Club home page Giter Club logo

Comments (11)

jeremy-murphy avatar jeremy-murphy commented on August 11, 2024 1

I just realized, after all this time, that maybe you can't see my email address on my GitHub profile. :)
That's OK, now that I've rediscovered this thread and reminded myself who you are, I'll tag you on other issues of importance. I think this is not the only issue related to maximum_weighted_matching.

from graph.

yi-ji avatar yi-ji commented on August 11, 2024

Thank you for the bug report, I've confirmed it. I will look into it for a fix (might take me some time).
Meanwhile this might be is helpful: the O(n^4) implementation in an earlier commit seems to be fine, regarding this problem.

from graph.

count0 avatar count0 commented on August 11, 2024

@yi-ji Thanks for looking into it.

However, when trying the O(n^4) implementation from the commit you mentioned, I also get a segfault for the same example...

from graph.

count0 avatar count0 commented on August 11, 2024

@yi-ji is there any update on this? Or at least a previous version that is known to work?

from graph.

jeremy-murphy avatar jeremy-murphy commented on August 11, 2024

If you have a minimal unit test that fails, I would be happy to merge that even without a fix.

Btw, if you two are regular users of BGL, we could do with help in terms of reviewing pull requests.
I don't have time to deeply check every pull request, and I don't actually expect other people to either, but at least if three people all agree that something looks good then we can merge it with some confidence.
And if it turns out to be bad, then no single person is to blame. ;)

from graph.

count0 avatar count0 commented on August 11, 2024

@jeremy-murphy The minimal unit test is here: https://gist.github.com/count0/551867e10973d4b2dc047b8528908281

I'd be happy to help reviewing pull requests.

from graph.

cmdawson avatar cmdawson commented on August 11, 2024

from graph.

jeremy-murphy avatar jeremy-murphy commented on August 11, 2024

Great. Can you all email me and we can start organizing.

from graph.

SneakyPeaky avatar SneakyPeaky commented on August 11, 2024

Can't boost just take any implementation from https://uoj.ac/problem/81 (see https://uoj.ac/submission/559649) ?
I am using the fastest implementation from there because boost fails with segfaults on random tests.

from graph.

jeremy-murphy avatar jeremy-murphy commented on August 11, 2024

Can't boost just take any implementation from https://uoj.ac/problem/81 (see https://uoj.ac/submission/559649) ? I am using the fastest implementation from there because boost fails with segfaults on random tests.

I can't merge it if you haven't made a pull request for it.

from graph.

SneakyPeaky avatar SneakyPeaky commented on August 11, 2024

Can't boost just take any implementation from https://uoj.ac/problem/81 (see https://uoj.ac/submission/559649) ? I am using the fastest implementation from there because boost fails with segfaults on random tests.

I can't merge it if you haven't made a pull request for it.

Oh, no, I mean why don't @yi-ji just base his implementation on the one from in UOJ? Just scratch the whole
maximum_weighted_matching and replace it with code in link I sent. It's clearly much better.

from graph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.