Comments (20)
I'll prioritise merging in the fix asap.
from graph.
Just an update, had to move twice, once across states, and started a new job. Getting back to this more now.
from graph.
Not sure if they are still active on Boost.Graph, but if someone submits a pull request to fix this issue, I can help them get it polished and merge it.
from graph.
@StahlTim @jeremy-murphy since there wasn't any real discussion beyond the branch/fix I linked a while back, I've put in a PR.
from graph.
@jzmaddock Hey, this looks like a good one for me to work on.
from graph.
Go for it!
from graph.
@arneboe Can I get your full name and email, since what you submitted is what I'm basing the regression test on? I need to credit you.
from graph.
I dont care about the credit, but if you have to: Arne Böckmann
from graph.
It looks like the intended design, given the state of BGL, is to have _map
a protected member, not a private member. So you hack was less of a hack than was expected.
from graph.
This may take longer than expected: https://github.com/boostorg/graph/blob/develop/include/boost/graph/adjacency_matrix.hpp#L992
from graph.
May be related: https://svn.boost.org/trac10/ticket/7863
from graph.
This is going to be delayed somewhat. There are general cleanups in testing which I need to do first.
from graph.
Sure, take your time! Better have it fixed correctly and thoroughly, than to rush it and only come up with some quick'n'dirty patch that fails somewhere else.
from graph.
Alright, no pressure. Just don't forget it ;-)
from graph.
And... it was forgotten
This bug really tripped me up when I tried to use labeled_graph
from graph.
As it seems... @anadon how's it going?
from graph.
Hey there, any update on it? @anadon by any chance do you still have your WIP PR that people can pick up from?
from graph.
This may be related:
There was a patch at https://svn.boost.org/trac/boost/ticket/9493 (I did not create it) which is no longer reachable, but I've been using it in production for years
I've preserved it here:
DeuceBox@de651cb
It appears to fix the bug in the minimal example given in the OP.
from graph.
@DeuceBox @jeremy-murphy
Is there currently an active pull request introducing the fix referenced by @DeuceBox?
Facing the same issue and would appreciate the fix being shipped with the stock boost library.
from graph.
Could someone please check out the fix I just merged and test it? Thanks to @DeuceBox for making the PR.
from graph.
Related Issues (20)
- A mistake in r_c_shortest_paths_example.cpp HOT 1
- `depth_first_visit_impl`: `finish_edge` not invoked when it should on MSVC HOT 2
- Algorithm for generating a random Flow Network/Graph HOT 1
- [Feature request] Implementation of Held-Karp lower bound for the TSP HOT 1
- Improve docs for ResourceExtensionFunction in r_c_shortest_paths
- Boost.Graph no longer builds with C++03 HOT 6
- astar_search does unnecessary initialization of vertices
- broken link to example for reverse graph adaptor HOT 6
- adjacency_matrix::add_vertex always aborts in Debug mode ? HOT 2
- Single-path RCSP does not return always the shortest path HOT 7
- Stack-overflow in boost::read_graphviz_detail::parser::parse_subgraph HOT 23
- Option to allow `breadth_first_search` to use `in_edges`
- Question on negative flow on arcs in Boykin-Kolmogorov algorithm -- meaning and interpretation
- Modular Boost C++ Libraries Request HOT 1
- read_graphml function rejecting well formed Graphml files HOT 1
- If using Boost::subgraph. Don't use Vertex_index_t.
- New near-linear time algorithm to solve the minimum cut problem for undirected graphs HOT 8
- CSR: Indexed properties maps are unstable
- creation of nested subgraphs by vertex descriptors is broken/unintuitive HOT 5
- kruskal_minimum_spanning_tree not working on filtered graph with weight map as named property
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graph.