Comments (6)
This is fixed in bolt 0.21.1!!
Thanks to @lachlanhunt for the PR.
from bolt.
Orly? I'll try to take a look today 👌
from bolt.
Ah okay. This is interesting, just thinking about the best way to resolve it.
Bolt doesn't exit automatically because we handle the errors ourselves in an external script (publish will actually return a list of packages that were successfully published and a list of unsuccessful attempts). That behaviour is probably not super consistent (commands should really use logging and exit codes, functions should return data).
We could either move the publish logic into an exposed function (similar to runWorkspaceTasks
, getDependencyGraph
, etc) and have the publish command just proxy to that, or we could add a flag to publish to tell it to exit on failure (either opt in or opt out).
Option 2 is probably easier, but option 1 is more correct...
from bolt.
I think we'll go with option 1.
@bradleyayers how much of a blocker is this for you? You could work around it pretty easily in the meantime (take a look at our script for reference). If it's urgent though, I'm happy to look at it this week?
from bolt.
Not a blocker for me, as it’s only happens when the NPM command fails, and that shouldn’t happen. It’s just a gotcha that I felt was worth raising so it can be fixed upstream. Thanks for looking into it!
from bolt.
Just an FYI, if you DO update to 0.21.1, be aware there was a minor breaking change, only if you were calling bolt.publish
from a node script. You'll just need to change it to bolt.publishPackages
and you'll be good though.
See #190
from bolt.
Related Issues (20)
- Missing `context` in `SlackCommandMiddlewareArgs` type HOT 2
- Bump yarn to 1.22
- Bolt add fails when adding a dot separated dependency in certain cases HOT 1
- Bolt add fails when using dist-tag versions if dependency already exists in workspaces
- Feature Request: Create the .npmrc file in each package HOT 6
- Packages with the same names leads to undefined behavior
- Bolt install production HOT 1
- Bolt doesn't work with Yarn 2
- Bolt hooks
- Documentation
- Is Bolt dead? HOT 3
- bolt: command not found HOT 2
- Project status HOT 4
- Bolt workspaces command to only run on modified workspaces HOT 1
- Install published packages instead of linking HOT 1
- Publish the package using publishConfig in the package.json file
- Is it using a database
- Don’t require packages’ dependencies to be declared in the root package.json HOT 2
- Shared directory for all workspaces
- ;)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bolt.