Explicit "unsafe" in session type language about dialectic HOT 2 OPEN

Related to this issue, the function into_inner is almost never correct to call, since it unconditionally discards the drop guards on the Chan and therefore will result in a runtime error if called within over, split, or call. It should be replaced with:

fn try_into_inner(self) -> Option<(Tx, Rx)> {
    // only return `Some` if drop guard is a unique `Arc`
}

Documentation should discourage the use of this function and refer to unsafe_with for situations where only temporary access to the raw transport is needed.

from dialectic.

Some may object to calling any of this "unsafe" since it cannot result in memory unsafety. Alternate nomenclature: Extern<P> type (alternatively: ExternCall?), extern; keyword (alternatively: extern call;? or extern _;?), extern_call function. This gets at the "this bit is not internally specified" notion, but without punning on the Rust meaning of "unsafe".

Presently, my favorite set of naming is Extern<P>/extern _;/extern_call.

from dialectic.