Giter Club home page Giter Club logo

Comments (2)

de-vri-es avatar de-vri-es commented on August 16, 2024 1

How about: find all Cargo.toml files at or below the current working directory, but to not crawl subdirectories if a Cargo.toml is found. Instead call cargo-metadata to find the workspace members and check those.

On problem I have now is that generated crates in the target directory also get checked. For example, trybuild generates a crate to run compile-fail tests. These may easily end up using less dependencies, but the generated crate copies all dependencies, just in case.

Alternatively, but more difficult I think: find all Cargo.toml files, but ignore target directories of workspaces. However, this still requires something like cargo-metadata to correctly identify the target directory.

from cargo-machete.

bnjbvr avatar bnjbvr commented on August 16, 2024

Thanks for opening an issue. I, for one, quite like that I could run the tool independently of workspaces in a directory that contained multiple Rust projects (unrelated to each other, i.e. no workspaces). And it'd be an API breaking change. So maybe we can introduce a CLI flag that respects the workspace by default.

Out of curiosity, you're saying it's useful in monorepos. Right now cargo-machete will look only for Cargo.toml file, so it only depends on the number of directories; do you see a large difference in runtime, when comparing:

  • running from the root
  • sum of (running in each directory belonging to the workspace)

from cargo-machete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.