Giter Club home page Giter Club logo

Comments (19)

bnb avatar bnb commented on August 28, 2024 5

Ah, okay. That looks and sounds 👍 to me.

from awesome-hyper.

sindresorhus avatar sindresorhus commented on August 28, 2024 4

@matheuss Could have the 5 most popular themes in the main readme and add everything else to a separate Markdown file.

from awesome-hyper.

bnb avatar bnb commented on August 28, 2024 1

@sindresorhus Yes, as @matheuss said there is a guideline that there's a visual representation - I always check themes for embedded images and frequently use a Saved Reply when the image doesn't work correctly.

Putting a comment at the top of themes might work saying that you can follow the link to see a screenshot might work (in addition to 5 best/most popular/top themes)?

from awesome-hyper.

keplersj avatar keplersj commented on August 28, 2024 1

@sindresorhus How did you show to color scheme at the top like you did in your screenshots?

from awesome-hyper.

matheuss avatar matheuss commented on August 28, 2024

I like the idea, especially because sometimes is hard to describe the theme with just a few words. My only concern is that the list would get too big 😰 What do you think @bnb?

from awesome-hyper.

lholznagel avatar lholznagel commented on August 28, 2024

How about a separate Markdown file, where all screenshots of the themes are available and in the main Markdown file a link to this file is created, so you only need to open this file when you want to see the screenshots.

from awesome-hyper.

bnb avatar bnb commented on August 28, 2024

I like the idea of a separate markdown file, with every awesome-item in README.md with an anchor to the correct theme image in the new file.

@sindresorhus Stars would be the only way I can think of to judge "most popular". Do you have other ideas?

from awesome-hyper.

sindresorhus avatar sindresorhus commented on August 28, 2024

I like the idea of a separate markdown file, with every awesome-item in README.md with an anchor to the correct theme image in the new file.

There's going to be hundreds of themes in a year and that will not scale if everything is listed in the main readme. That's why I suggested showing the most popular ones or the prettiest ones (very subjective though) and then more in a separate file.

Stars would be the only way I can think of to judge "most popular". Do you have other ideas?

You want usage popularity, not star popularity. Look at the npm download numbers instead.

from awesome-hyper.

bnb avatar bnb commented on August 28, 2024

@sindresorhus Sorry, I don't think I communicated effectively - I was agreeing.

I was thinking along these lines:

[hyperterm-theme](https://www.npmjs.com/package/hyperterm-theme) - [View Theme](./THEME-IMAGES.md) - Dark - Awesome description

hyperterm-theme - View Theme - Dark - Awesome description

Where every theme has a hyperlink (View Theme) to the theme images file, with an anchor to the correct theme.

from awesome-hyper.

sindresorhus avatar sindresorhus commented on August 28, 2024

I think I'm the one that didn't communicate effectively ;) I got what you meant, but I don't think it will scale even with just text links, when it grows to hundreds of themes.

from awesome-hyper.

matheuss avatar matheuss commented on August 28, 2024

I like the idea of having a "Top 5" or something in the main readme, but I don't think that a separate file is necessary since one of the guidelines is:

There is a visual representation of what my plugin does in the repo

Because of that, the View Theme link could lead you to the npm/repo of the theme 😊

from awesome-hyper.

sindresorhus avatar sindresorhus commented on August 28, 2024

Because of that, the View Theme link could lead you to the npm/repo of the theme

But then we're back to the user having to follow every single link to view all the themes.

To be completely clear, here's what I'm proposing in the main readme.md:


Themes

Showing top 5. View all.

Snazzy

Another

Yet Another

Unicorn

Rainbow

See all themes

from awesome-hyper.

keplersj avatar keplersj commented on August 28, 2024

bump?

from awesome-hyper.

bnb avatar bnb commented on August 28, 2024

@keplersj Feel free to submit a PR! Would be happy to implement this 🤗 I'm just not 100% sure what the best way to do this is - pull the images from the npm repos is probably an easy bet.

Additionally, what's our best bet on determining which have the most downloads quickly, and updating when that changes? I don't want to take an instant snapshot of the best right now and then update every so often if there's a better way to do it.

from awesome-hyper.

keplersj avatar keplersj commented on August 28, 2024

@bnb If I have some time this weekend I'll give it a shot

from awesome-hyper.

bnb avatar bnb commented on August 28, 2024

@keplersj Awesome - looking forward to it, if you can! 🙏

from awesome-hyper.

sindresorhus avatar sindresorhus commented on August 28, 2024

See: sindresorhus/hyper-snazzy#4

from awesome-hyper.

iamstarkov avatar iamstarkov commented on August 28, 2024

is there any hyper-switch plugin to find out which themes works the best way with your code?

from awesome-hyper.

iamstarkov avatar iamstarkov commented on August 28, 2024

smth like vs code has

from awesome-hyper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.