[Feature request] Hide "Start tensorboard" buttons with cli argument. about kohya_ss HOT 6 CLOSED

Nice works!
Although not the way I originally thought, it does fit my needs.

I noticed a small detail.
Your detection is on tensorflow package, changing the text to TensorFlow is not installed, hiding the tensorboard button... would be more accurate.

from kohya_ss.

Will push that to dev in the next commit.

from kohya_ss.

Interesting work for docker users. I like the idea of building it as part of a pipeline so users can trust it is coming from the right source.

hiding the tensotboard via a cli parameter should be doable… I will check how much work would be required.

from kohya_ss.

Regarding the lack of tensorboard in the image... This might confuse some users that are used to have it... I don't know how I feel about feilding issues of users constantly reporting that the tensorboard support is broken... Would there not be a way to not package tensorboard in the image... but for users who want to use it to dynamically install the missing modules? Python should be able to install missing modules and maintain functionality? Or perhaps leave the button but log a warning when a user click it in the docker image stating that this image does not support tensorboard to stay lean?

from kohya_ss.

I believe Docker users will know that TensorBoard is already running when they see this.

You can install tensorboard on the fly, but docker cannot dynamically establish port mapping. So this won't work.
Currently, when you do not have tensorboard installed and press the button, it will write an error in the console (rather than crashing), which is good enough.
I think there won't be any actual difference if we just add a warning in the console.
It would be clearer to just hide it.

Perhaps we can write about this situation in the README of docker section.
Let them know that this is "by design".

from kohya_ss.

The latest dev branch code will no longer show the tensorboard button if tensorflow is not installed.

from kohya_ss.